-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VV: Add VolumetricViewer to lib-subject-viewers
#6349
Conversation
233960f
to
2898989
Compare
0644c14
to
dae1d23
Compare
lib-subject-viewers
lib-subject-viewers
bf34584
to
269d0ba
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code read mostly looks good! Per our conversation earlier today this PR copies some of the viewer code from brainsweeper.zooniverse.org into lib-subject-viewers with plans to break up the code into smaller pieces for later integration into the classifier.
However, I'm now having trouble running this branch locally, so could you check a couple of things for me?
canvas
andwatch
are added to the package.json, but I see no changes to yarn.lock. Either double check that you installed these third party libraries viayarn add [package]
, or simply runyarn
at the front-end-monorepo root. Because this is a monorepo workspace, installation of new third party libraries will result in changes to the yarn.lock file.- I noted in Slack that Node released a new version of lts/iron today and that it actually affected my ability to bootstrap FEM locally. I can bootstrap the master branch, but when I try to bootstrap this PR branch locally, I immediately get errors about
canvas
, so that could be caused by my first point above, but also please check which version of Node you're using locally. For consistency, it'll be easier to debug if we're both using the same version of Node and the same version as the CI action.
269d0ba
to
c36885c
Compare
@goplayoutside3 - I had originally excluded the |
4036d1d
to
c36885c
Compare
- Add "data-testid" to all DOM elements we want to test for existence - Add PropTypes to all Components based on linter output - Add shims for Canvas, WebGL, and requestAnimationFrame for Cube rendering and testing - Restructure VolumetricViewer directory to have all components, css, data, helpers, models, and tests in respective directories - Specs for AlgorithmAStar - Specs for ModelAnnotation - Specs for ModelTool - Specs for ModelViewer - Specs for pointColor - Specs for SortedSet - Specs for VolumetricViewer that simply tests for existence in the DOM - Write skeleton of a README
c36885c
to
5daf24b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm using a Macbook with M1 chip and installing canvas
locally for the VolumetricViewer requires extra setup. Instructions can be found here Automattic/node-canvas#1511.
@kieftrav I opened #6385 to document troubleshooting the new viewer. Please merge it into this PR and you're good to go 👍
I had originally excluded the yarn.lock changes as per a previous conversation we had had. Just added it.
Changes to the yarn.lock file should always be included in PRs. For instance, when a new third-party library is added to FEM, the monorepo tracks versioning of those libraries in yarn.lock. There may have been some misunderstanding in past conversations, but yarn.lock is crucial to the monorepo workspace.
lib-subject-viewers
lib-subject-viewers
Package
lib-subject-viewers
Describe your changes
How to Review
lib-subject-viewers
in Storybook. Should load the 3 Plane frames on the left and the 1 3D Cube on the right. No spec testing of Components beyond "does it load" in favor of Storybook testing for UI usage & needing to incorporate FigmaModelAnnotations
has a half-finished implementation of History. I plan on finishing that in a follow up PR** Note: The last 2 commits were to get the GH
ci:test
to pass. I couldn't figure out how to get thegl
package to build in that context. Running tests locally without the last 2 PR's removing that works locally. I'd appreciate guidance on if we want to spend more time gettinggl
to work for the ci testrunner... Because the main point of it is to make sure the components load. If we're relying on Storybook for these components + unit testing the underlying Models, I think we'd be all right.General
yarn panic && yarn bootstrap
ordocker-compose up --build
and FEM works as expectedNew Feature