fix(lib-classifier): refresh expired bearer tokens #6604
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eatyourgreens
force-pushed
the
fix-quick-talk
branch
from
d1fac3b to
9000e48
Compare
eatyourgreens
force-pushed
the
fix-quick-talk
branch
2 times, most recently
from
56e4739 to
4c9d54b
Compare
eatyourgreens
force-pushed
the
fix-quick-talk
branch
from
4c9d54b to
a726c16
Compare
eatyourgreens
commented
Jan 30, 2025
Comment on lines
-12
to
-14
| useEffect(function onUserChange() { | ||
| checkAuth() | ||
| }, [authClient, userID]) |
There was a problem hiding this comment.
The original bug happens because this hook stores your bearer token in component state and reuses it forever, even after it has expired. The token should be checked (by running checkAuth()) every time that it's used.
There was a problem hiding this comment.
Tip
General tip for reviewing React components: whenever you see useEffect it has probably introduced a subtle bug.
eatyourgreens
force-pushed
the
fix-quick-talk
branch
from
a726c16 to
d296240
Compare
eatyourgreens
force-pushed
the
fix-quick-talk
branch
from
d296240 to
10af1e4
Compare
Fix `usePanoptesAuth` hook to refresh expired bearer tokens in the classifier. Fixes a bug where Quick Talk stops working once your bearer token expires.
eatyourgreens
force-pushed
the
fix-quick-talk
branch
from
10af1e4 to
377b80a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix
usePanoptesAuthhook to refresh expired bearer tokens in the classifier. Fixes a bug where Quick Talk stops working once your bearer token expires.Please request review from
@zooniverse/frontendteam or an individual member of that team.Package
Linked Issue and/or Talk Post
How to Review
The original issue (#6594) happens if you leave the classifier open long enough for your bearer token to expire, so you might need to open the classifier in a tab and leave it for a couple of hours. With the changes here, an expired token should always be refreshed, as long as you don't allow your Panoptes refresh token to expire. I think refresh tokens are good for up to 2 weeks.
Checklist
PR Creator - Please cater the checklist to fit the review needed for your code changes.
PR Reviewer - Use the checklist during your review. Each point should be checkmarked or discussed before PR approval.
General
yarn panic && yarn bootstrapordocker-compose up --buildand FEM works as expectedGeneral UX
Example Staging Project: i-fancy-cats
Bug Fix