Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DRAFT] lib-classifier: Show survey task ChoiceButton thumbnail, if greater than 30 choices #6609

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mcbouslog
Copy link
Contributor

Package

  • lib-classifier

Linked Issue and/or Talk Post

Describe your changes

  • removes whatSizeThumbnail condition when there are greater than 30 choices
  • before these changes, a workflow with survey task and thumbnail property NOT set to "hide" showing (pre or post applied filters) greater than 30 choices would NOT show a thumbnail in the ChoiceButton
  • after these changes, a workflow with survey task and thumbnail property NOT set to "hide" showing (pre or post applied filters) greater than 30 choices would show a thumbnail in the ChoiceButton
  • these changes do not impact a workflow with survey task thumbnail property is set to "hide"

How to Review

Helpful explanations that will make your reviewer happy:

  • What Zooniverse project should my reviewer use to review UX?
  • What user actions should my reviewer step through to review this PR?
  • Which storybook stories should be reviewed?
  • Are there plans for follow up PR’s to further fix this bug or develop this feature?

Checklist

PR Creator - Please cater the checklist to fit the review needed for your code changes.
PR Reviewer - Use the checklist during your review. Each point should be checkmarked or discussed before PR approval.

General

  • Tests are passing locally and on Github
  • Documentation is up to date and changelog has been updated if appropriate
  • You can yarn panic && yarn bootstrap or docker-compose up --build and FEM works as expected
  • FEM works in all major desktop browsers: Firefox, Chrome, Edge, Safari (Use Browserstack account as needed)
  • FEM works in a mobile browser

General UX

Example Staging Project: i-fancy-cats

  • All pages of a FEM project load: Home Page, Classify Page, and About Pages
  • Can submit a classification
  • Can sign-in and sign-out
  • The component is accessible

Refactoring

  • The PR creator has described the reason for refactoring
  • The refactored component(s) continue to work as expected

@coveralls
Copy link

Coverage Status

coverage: 77.351% (-0.05%) from 77.398%
when pulling 3791e3c on lib-classifier_survey-task-dynamic-thumbnails
into ad3222c on master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants