Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VolumetricViewer - Buttons Toolbar & mark undo() + delete() #6656

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

kieftrav
Copy link
Contributor

@kieftrav kieftrav commented Jan 30, 2025

Please request review from @zooniverse/frontend team or an individual member of that team.

Package

  • lib-classifer
  • lib-subject-viewer

Describe your changes

  • Finish integrating mark.undo() and mark.delete() for VolumetricViewer
  • Fix accessibility issues with VolumetricViewer as seen is Storybook
  • Update tests to include mark.undo() and mark.delete()

How to Review

  • All specs should pass
  • Subject Viewers Storybook: Subject Viewers > VolumetricViewer
    • There should no longer be any accessibility issues
  • Classifier Storybook: Tasks > Volumetric
    • Load Staging VV Project in local Classifier and ensure that clicking on the cube / plane creates an annotation and the TaskArea tool updates to {n} drawn.
    • Test that clicking "undo" removes the last added points to the mark
    • Test that clicking "delete" removes the mark from the TaskArea
    • Submit classification and inspect that the classification has annotation data. Deleted marks will show as having no data in their points but will still exist

** Note: Design review will be requested in the next PR, which will incorporate all of Sean's current feedback. Specific items I'd like to call out are:

  • Undo/Delete button styling in the Volumetric View
  • Clicking "collapse/expand" to collapse+expand
  • Removing the Toolbar (whether a new layout or some other method to be discussed) and moving the FieldGuide

Checklist

PR Creator - Please cater the checklist to fit the review needed for your code changes.
PR Reviewer - Use the checklist during your review. Each point should be checkmarked or discussed before PR approval.

General

  • Tests are passing locally and on Github
  • Documentation is up to date and changelog has been updated if appropriate
  • You can yarn panic && yarn bootstrap or docker-compose up --build and FEM works as expected
  • FEM works in all major desktop browsers: Firefox, Chrome, Edge, Safari (Use Browserstack account as needed)
  • FEM works in a mobile browser

General UX

Example Staging Project: i-fancy-cats

  • All pages of a FEM project load: Home Page, Classify Page, and About Pages
  • Can submit a classification
  • Can sign-in and sign-out
  • The component is accessible

@kieftrav kieftrav marked this pull request as draft January 30, 2025 15:19
@kieftrav kieftrav force-pushed the vv-buttons branch 2 times, most recently from 79bc425 to acb026f Compare February 3, 2025 13:55
@coveralls
Copy link

coveralls commented Feb 3, 2025

Coverage Status

coverage: 75.5% (+1.4%) from 74.088%
when pulling 5d4d126 on vv-buttons
into 5a0fd17 on master.

@kieftrav kieftrav changed the title WIP: VolumetricViewer - Buttons for Interaction VolumetricViewer - Buttons Toolbar & mark undo() + delete() Feb 3, 2025
@kieftrav kieftrav marked this pull request as ready for review February 3, 2025 14:59
- Finish integrating mark.undo() and mark.delete() for VolumetricViewer
- Clean up image toolbar to only allow annotating
- Fix accessibility issues with VolumetricViewer as seen is Storybook
- Update tests to include mark.undo() and mark.delete()
- Clicking on a Mark switches the active annotation Mark in both the volumetric and planar view
- Active vs Inactive marks have different coloring
- Miscellaneous small bug fixes / edge cases
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants