-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(a11y): Volumetric Viewer slider control #6708
base: master
Are you sure you want to change the base?
Conversation
8fa94ee
to
74f1029
Compare
packages/lib-subject-viewers/src/VolumetricViewer/components/Slider.js
Outdated
Show resolved
Hide resolved
Hey @eatyourgreens the volumetric viewer is still in active development. @kieftrav has a PR incoming with very similar changes to address both design and some accessibility considerations. In the future please don't focus on code for features that are not yet publicly launched via a Zooniverse project. In the meantime I'll tag @kieftrav to see if he'd like to review this PR, or include the fix in his own. |
OK but heads up that the code at present fails WCAG level A in several places. |
74f1029
to
315b665
Compare
A couple of small fixes for the slider control: - a labelled button to advance by 10 frames (keyboard and screen reader operability is a level A WCAG requirement for clickable controls.) - `::moz-range-thumb` styling for Firefox.
315b665
to
7f7e4f4
Compare
6c7bb4a
to
3314386
Compare
It would be very good to fix the expandable panels so that they are coded as accordian panels, not divs with onClick handlers (and zero keyboard or screen reader accessibility.) Tested in the Volumetric Viewer storybook, using Tab (or VO-RIght Arrow) to access the viewer controls, and VoiceOver to read the panel roles and states. There's also a complete lack of visual focus indicators, to tell you where keyboard focus is at any time. |
A couple of small fixes for the slider control:
::moz-range-thumb
styling for Firefox.Tested with Chrome, Firefox, and Safari on MacOS 14.7.3.
Please request review from
@zooniverse/frontend
team or an individual member of that team.Package
How to Review
You can try out these changes in the storybook. The slider control should be operable from the keyboard on this branch, but not on the main branch.
http://localhost:6008/?path=/story/components-volumetricviewer--volume-64-x-64-x-64
Note that the slider control can't be used with a pointer device (mouse, trackpad etc.) in Firefox. That isn't fixed here.I've also fixed the slider so that you can now use it in Firefox.Checklist
PR Creator - Please cater the checklist to fit the review needed for your code changes.
PR Reviewer - Use the checklist during your review. Each point should be checkmarked or discussed before PR approval.
General
yarn panic && yarn bootstrap
ordocker-compose up --build
and FEM works as expectedGeneral UX
Example Staging Project: i-fancy-cats
Bug Fix