-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(drawing-tools): transcription line handles on smaller screens #6727
base: master
Are you sure you want to change the base?
fix(drawing-tools): transcription line handles on smaller screens #6727
Conversation
Adjust the transcription line tool to use smaller handles on screens less than 900px wide. This may help with a problem where the line handles obscure the underlying text on tablets, or smaller desktop viewports.
This is the delete button position with a negative, rather than positive, buffer ie. button to the left of the first point. ![]() If you're wondering why the delete button is so far away from the start of the line, there's a minimum separation between touch/click targets that I'm trying to adhere too: WCAG 2.5.8: Target Size (minimum.) The delete button and the drag handle at the start of the line might still fail the overlapping 24px circle test: https://www.w3.org/WAI/WCAG22/Understanding/target-size-minimum.html#target-spacing-toolbar My rough test is: when I have my finger on the first point of the line, is it also clicking the delete button? Is there sufficient affordance for people with shaky hands? Transcription workflows, in particular, might need affordances for an older audience. |
6471575
to
dc84a93
Compare
dc84a93
to
1995b38
Compare
Delete button position now follows the line rotation angle on this branch, so that the delete button always precedes the start of the line. Screen.Recording.2025-02-28.at.14.35.45.mov |
b2f79dc
to
9e5d915
Compare
Please request review from
@zooniverse/frontend
team or an individual member of that team.Package
lib-classifier/plugins/drawingTools
Linked Issue and/or Talk Post
How to Review
The drag handles at the ends of transcription lines should be a more reasonable size here, on smaller screens.
I don't think theUpdated to include the delete button too. The delete button position should also adjust when a line is rotated (#6727 (comment))HANDLE_RADIUS
constant affects the delete button, though.See #6723 (comment) for a screenshot of the line handles obscuring text on an iPhone.
Documentation Detectives in the dev classifier: https://localhost:8080/?project=bmtcollections/documentation-detectives-transcribing-accession-registers&env=production&workflow=26197
Checklist
PR Creator - Please cater the checklist to fit the review needed for your code changes.
PR Reviewer - Use the checklist during your review. Each point should be checkmarked or discussed before PR approval.
General
yarn panic && yarn bootstrap
ordocker-compose up --build
and FEM works as expectedGeneral UX
Example Staging Project: i-fancy-cats
Bug Fix