Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused dependencies from VV. #6754

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kieftrav
Copy link
Contributor

Package

  • lib-subject-viewers

Describe your changes

Conversation started from Slack and a dependency bump for an unused package. This cleans up the two no-longer-used packages that were used when the VolumetricViewer was under more intensive development.

How to Review

  • Tests pass

@kieftrav kieftrav requested a review from goplayoutside3 March 11, 2025 15:22
@coveralls
Copy link

Coverage Status

coverage: 75.472% (+0.03%) from 75.442%
when pulling 5381fde on vv-unused-dependencies
into ba7abe0 on master.

@goplayoutside3
Copy link
Contributor

@kieftrav when you edited the package.json for lib-subject-viewers, did you run yarn at the front-end-monorepo root? Un-installation of dependencies results in changes to the yarn.lock file, which I don't see in this PR yet.

Another way to do uninstallation is with the yarn remove canvas and yarn remove watch commands in lib-subject-viewers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants