Maintenance work and django upgrade #404
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR came about due to the need to update Django package. Sadly the existing package manager
pipenvfailed in it's jobs to do so as it either wouldn't update the package in isolation (pypa/pipenv#2412 (comment)) or it would update everything including Django.Sadly this application has 0 tests so we can't verify system behaviour without manual testing. This also means we are in trouble when bulk update all the dependencies.
Acknowledging the long running issues with
pipenv, I decided to switch to the poetry package manager which just worked™️. I used the https://pypi.org/project/pipenv-poetry-migrate/ to migrate our current Pipfile to a poetry project file and then installed updated the packages**.As such this PR provides the Django upgrade we desired and a more functional development / testing environment for future work.
** this did indeed update some packages that had less restrictive version constraints in the Pipfile and thus required manual testing of the system as it stood. I manually tested the servers & workers start via
docker-compose upand i could access the project home pages and click around without error. More testing will be done on the main deployment, sadly as this has no staging system deployment :sadpanda: