Project listing #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simoneduca
suggested changes
May 26, 2017
| @@ -26,12 +26,12 @@ const projectContentsReducer = (state = initialState, action) => { | |||
| }; | |||
|
|
|||
| // Action Creators | |||
| const fetchProjectContents = () => { | |||
| const fetchProjectContents = (project_id) => { | |||
There was a problem hiding this comment.
You're requesting project_contents with project_id, which isn't right. project_contents id is needed, which available in project links.
There was a problem hiding this comment.
My bad, this should actually be requesting a list of all ProjectContents resources for a given project, then listing them by language.
simoneduca
reviewed
May 26, 2017
src/ducks/contents.js
Outdated
| @@ -31,7 +31,10 @@ const fetchProjectContents = (project_id) => { | |||
| dispatch({ | |||
| type: FETCH_PROJECT_CONTENTS, | |||
| }); | |||
| apiClient.type('project_contents').get(project_id) | |||
| const query = { | |||
| project_id: project_id | |||
There was a problem hiding this comment.
Shorthand property is nicer perhaps?
Only display the first for now.
eatyourgreens
force-pushed
the
project-list
branch
from
d98ad5b to
519aec7
Compare
simoneduca
approved these changes
May 30, 2017
|
LGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a basic project listing, linking each project up to the project contents view.