Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add translation keys to field guides #39

Merged
merged 1 commit into from
Jul 20, 2017
Merged

Add translation keys to field guides #39

merged 1 commit into from
Jul 20, 2017

Conversation

eatyourgreens
Copy link
Contributor

Relies on #38 for the translation text to show up in the editor but these two can be merged in any order.

@eatyourgreens eatyourgreens requested a review from simoneduca July 20, 2017 13:23
@eatyourgreens eatyourgreens mentioned this pull request Jul 20, 2017
Open
18 tasks
@simoneduca
Copy link
Contributor

simoneduca commented Jul 20, 2017 •
edited
Loading

After merging this with changes in #38, I can see my translation inside the editor. Is this what is expected @eatyourgreens ?
screen shot 2017-07-20 at 14 50 23

@eatyourgreens
Copy link
Contributor Author

@simoneduca 👍

@eatyourgreens eatyourgreens merged commit 0c0c5dc into master Jul 20, 2017
@eatyourgreens eatyourgreens deleted the translate-field-guides branch July 20, 2017 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simoneduca simoneduca simoneduca approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eatyourgreens @simoneduca