Improve project linking workflows API end point #3626
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
copy the workflow and add to the projects.workflows relation instead of duplicating
![hound[bot]](https://avatars.githubusercontent.com/in/3598?s=60&v=4){kind=small}
| expect(resource.workflows.first.id).to_not eq(workflow.id) | ||
| end | ||
| end | ||
|
|
||
| context "copy linked subject_set" do | ||
| context 'copy linked subject_set' do |
There was a problem hiding this comment.
RSpec/NestedGroups: Maximum example group nesting exceeded [4/3].
RSpec/ContextWording: Start context description with 'when', 'with', or 'without'.
| context "copy linked workflow" do | ||
| it 'should have the same tasks workflow' do | ||
| expect(resource.workflows.first.tasks).to eq(workflow.tasks) | ||
| context 'copy linked workflow' do |
There was a problem hiding this comment.
RSpec/NestedGroups: Maximum example group nesting exceeded [4/3].
RSpec/ContextWording: Start context description with 'when', 'with', or 'without'.
This was referenced Jul 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When linking workflow(s) to a project the current behaviour is to duplicate the workflow and save a new copy. This duplicate is basic and copies over existing context and values that make little or no sense in the new project (classification counts etc) while not allowing us to copy workflow relations (e.g. translations etc)
This PR introduces a
WorkflowCopierclass that allows custom copying logic for the Workflow resource and copy the translation resources as well.This
WorkflowCopierclass is now used instead of the basic AR.dupmethod in the controller action to update the link relations.Additionally - my laptop was going crazy 'monitoring' the project files via guard (I may be the only one that uses this) so i updated the guard dependencies (improve the underlying FS libs for monitoring changes) and config (to reduce the number of files we are 'monitoring'). This massively improved the system for me and doesn't impact the behaviour of this PR just how i run my dev setup.
I realize this is an unrelated addition to the PR and if folks feel strongly i'll remove to it's own PR.
Review checklist
apiary.apibfile?