-
-
Notifications
You must be signed in to change notification settings - Fork 259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: Implement custom fade out duration #405
feature: Implement custom fade out duration #405
Conversation
@TheNerdGuyLulu There's a small issue here (not in the PR, but in the feature). The feature might exists, but it needs to be clamp at 220 (native side equivalents of |
@zoontek Thanks for such quick code review. |
@zoontek Wouldn't be enough to use |
@TheNerdGuyLulu Yeah, close enough to do it on the JS side |
@zoontek CR comments addressed 🤞🏻 |
@zoontek |
LGTM, thanks |
Summary
This feature implements a custom duration for the splash screen fade out.
The parameter is optional, with the default being 220ms, as it was already before, making it backwards compatible without any changes for the current consumers.
Test Plan
What's required for testing (prerequisites)?
Android emulator & iOS simulator is enough.
What are the steps to test it (after prerequisites)?
Compatibility
Checklist
README.md
example/App.tsx
)The current example project isn't "visually" compatible with this feature, as the logo is hidden from JS.