-
-
Notifications
You must be signed in to change notification settings - Fork 840
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
App Rejected in AppStore #266
Comments
It does actually explain in the readme that you need to add some keys to the plist. App Store submission disclaimer Did you include the items in your plist? |
I've just received App Store Review Team's notice. They told me the info.plist should include the description with more realistic "usage example". To avoid rejection I'd suggest fork this repo and remove unnecessary permissions. |
Yeah that’s what they say, if you declare permissions in plist you better include why your app would need to prompt for these permissions. “usage example” doesn’t cut it anymore hence why I suggest we leave this repo for Android only and split each permission in it’s own module. |
We are also being rejected for this reason - We obviously have no need for Apple Music so there's nothing in the permissions info.plist that we can put for that. Looks like this means that including this library in your react-native project will mean that you cannot submit an iOS app to the app store unless you are using every single on of the permissions. |
In the description have you tried simply entering something like "This permission is requested for the purpose of utilizing the react-native-permissions library and is not actually used by the app"? The library references lots of different permissions so that you can properly call the ones you need within your app, but apple isn't able to tell that they are not being used, it can only see that they are referenced in the code of this library. If "Usage Example" isn't sufficient anymore, a full explanation of why your library mentions all of these permissions seems like what they're looking for, no? |
Has anyone had any success with @Gradner suggestion? |
I actually submitted my app with that suggestion the day I posted it and it's accepted! :) Again, they just want a reasonable enough explanation as to why your code references those permissions, even if it's not utilizing them in a functional way. Worked like a charm! Just make sure you include all the pertinent permissions listed in the readme. Example of mine below:
|
Here is a fork that doesn't have 'event', 'reminder', 'bluetooth', 'speechRecognition', or Apple Music. https://github.com/woodpav/react-native-permissions Relevant commit: https://github.com/woodpav/react-native-permissions/commit/7034bc8b485d580967e2b2469846eca1da60cfbb |
We started using this library but didn't want to have a phantom usage descriptions, so I've created #276 |
@woodpav Thank you for this fork! I started using it today. Any particular reason why you left the Motion Usage permission in there? I just tried to submit an app to the using your fork and this is the last issue Apple is complaining about. |
@timkuilman I'm using motion ;) Take a look at the commit to remove it on your fork. |
I am closing this since this issue does not exists anymore with the 2.0.0 release. |
For those that get caught out removing it in v2 like I did. Permission-MediaLibrary and Permission-StoreKit both use NSAppleMusicUsageDescription. You can search in your node modules folder for the permission to see which module is using it. |
It reproduced on 2.2.0 |
Im using 2.2.2 and the NSAppleMusicUsageDescription bug is still happening. |
@ghost I am using 3.0.2. is NSAppleMusicUsageDescription bug still exists in latest version as well. I haven't check it since I have not submitted my app to store.So can you please let me know if you had already submitted app to store.? |
@zoontek Has this issue been completely resolved in recent versions? |
If you are not using a module that requires it (apparently MediaLibrary and StoreKit) from the above then it should be fine. If you are then you need to include the description. You should try it and report back. |
@mikehardy I am using MediaLibrary and mentioned it in info.plist. But not StoreKit. Now , Do I have to mention about store kit as well? |
@Yandamuri I don't use those modules so I don't have a definitive answer. Suggest looking at the actual implementation to see the actual iOS API calls made, check the related documentation and verify directly. A bit tedious but way better than waiting for an App Store review / reject / re-submit cycle. |
@Yandamuri I don't use this kind of permissions either. Please submit yours and give feedback. |
When I put NSAppleMusicUsageDescription to an info.plist through VSCode, it changes to Privacy - Media Library Usage Description in XCODE. I think there is some miss on this part. If you guys still have issue, write description about media library. |
Describe your environment
How to repeat issue and example
Add
"react-native-permissions": "^1.1.1",
to package.json and submit to AppStore to use it only to detect a single permission.Apple Rejects app:
I only need it to detect push notifications, not bluetooth, speech recognition, etc.
Solution
Deprecate this library and split the logic detection into multiple libraries with a single detection feature per library that only link to specific apple frameworks.
The text was updated successfully, but these errors were encountered: