add NSAppleMusicUsageDescription permission to play audio messages to… #20264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
siddarthkay
requested changes
May 30, 2024
There was a problem hiding this comment.
@jo-mut : according to https://developer.apple.com/documentation/bundleresources/information_property_list/nsapplemusicusagedescription this permission is to read from music library so we should adjust the message in info.plist accordingly
Also would be nice to revert the entry from StatusImTest/info.plist
Jenkins BuildsClick to see older builds (8)
|
siddarthkay
reviewed
May 30, 2024
ios/StatusIm/Info.plist
Outdated
| @@ -82,6 +82,8 @@ | |||
| <string>Photos access is required to give you the ability to save images.</string> | |||
| <key>NSPhotoLibraryUsageDescription</key> | |||
| <string>Photos access is required to give you the ability to send images.</string> | |||
| <key>NSAppleMusicUsageDescription</key> | |||
| <string>Play audio messages</string> | |||
There was a problem hiding this comment.
should be A message that tells the user why the app is requesting access to the user’s media library.
There was a problem hiding this comment.
@siddarthkay and do we really use the music lib
There was a problem hiding this comment.
I mean I am not really aware of why we use the media lib, do you know at least i could write a more informative message
There was a problem hiding this comment.
my assumption is most likely because we request permission to media library here :
Line 19 in 5559599
media includes both images + music.
There was a problem hiding this comment.
I see, its not just music. thats right
There was a problem hiding this comment.
it was added in react-native-permissions library here -> zoontek/react-native-permissions@001f633 which strengthens my assumption that media permission require us to add NSAppleMusicUsageDescription in info.plist
There was a problem hiding this comment.
I am currently looking to see if we actually need the permission as you have suggested, this pr however should be ready, you could approve it so I can run the e2e tests in the meantime
There was a problem hiding this comment.
hmm e2e tests wont help us though. since this is iOS specific. e2e will only validate Android.
There was a problem hiding this comment.
better to ask @status-im/mobile-qa to take a look at PR build on iOS after you make the changes
jo-mut
force-pushed
the
chore/info.plist-permissions
branch
from
3940052 to
30c3928
Compare
|
also relevant -> zoontek/react-native-permissions#266 (comment)
|
siddarthkay
reviewed
May 30, 2024
ios/StatusIm/Info.plist
Outdated
| @@ -82,6 +82,8 @@ | |||
| <string>Photos access is required to give you the ability to save images.</string> | |||
| <key>NSPhotoLibraryUsageDescription</key> | |||
| <string>Photos access is required to give you the ability to send images.</string> | |||
| <key>NSAppleMusicUsageDescription</key> | |||
| <string>Read media files</string> | |||
There was a problem hiding this comment.
Suggested change
| <string>Read media files</string> | |
| <string>Status uses Media Library to save and send Images. The Media Library module internally requires permissions to Apple Music.</string> |
siddarthkay
approved these changes
May 30, 2024
jo-mut
force-pushed
the
chore/info.plist-permissions
branch
from
30c3928 to
d978b74
Compare
|
I think for now its best to just include the public string and if we need to remove the medialib later because its not necessary we can do that on develop |
jo-mut
force-pushed
the
chore/info.plist-permissions
branch
from
d978b74 to
6f6f8aa
Compare
86% of end-end tests have passedNot executed tests (1)Failed tests (3)Click to expandClass TestDeepLinksOneDevice:
Class TestWalletMultipleDevice:
Expected to fail tests (4)Click to expandClass TestGroupChatMultipleDeviceMergedNewUI:
Class TestCommunityOneDeviceMerged:
Class TestWalletOneDevice:
Passed tests (44)Click to expandClass TestActivityMultipleDevicePR:
Class TestCommunityMultipleDeviceMergedTwo:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestDeepLinksOneDevice:
Class TestCommunityOneDeviceMerged:
Class TestWalletOneDevice:
Class TestCommunityMultipleDeviceMerged:
Class TestActivityMultipleDevicePRTwo:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #20234
Summary
This seems to be a permission required by apple store because we have the feature to play audio messages
status: ready