Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix RN import priority, favoring newest version of RN (Adds to #138 and #139) #146

Merged
merged 1 commit into from
Sep 26, 2017

Conversation

TikiTDO
Copy link
Contributor

@TikiTDO TikiTDO commented Sep 14, 2017

Fixes imports for iOS files in RN 0.48 and newer, similar to #138 and #139, but with a more consistent and backwards compatible style.

@TikiTDO TikiTDO changed the title Fix RN import priority, favoring newest version of RN Fix RN import priority, favoring newest version of RN (Adds to #138 and #139) Sep 14, 2017
@MoOx
Copy link
Collaborator

MoOx commented Sep 15, 2017

#138 (comment)

@zoontek
Copy link
Owner

zoontek commented Sep 19, 2017

@yonahforst Any ETA on this? Do you need some collaborators?

@dotansimha
Copy link

dotansimha commented Sep 20, 2017

Any chance to merge it soon?

@vitorebatista
Copy link

Please, merge it asap.

@kelset
Copy link
Collaborator

kelset commented Sep 25, 2017

@yonahforst can you get this merged and release a new version?

In the meantime, this fix is usable by writing, in package.json:

    "react-native-permissions": "TikiTDO/react-native-permissions#008bc68",

@yonahforst yonahforst merged commit 75f1d79 into zoontek:master Sep 26, 2017
@yonahforst
Copy link
Collaborator

@TikiTDO - thanks for this PR!

@everyone - I'm not actively working on any RN projects right now, so it's hard to find time to maintain this lib. If anyone is interested in collaborating, please let me know.

@kelset
Copy link
Collaborator

kelset commented Sep 27, 2017

@yonahforst I know how you feel, I wish I had time to dedicate to it :(
Maybe ping the guys from the React Community if they can take this over?


btw ETA for new release with this fix? 😇

@zoontek
Copy link
Owner

zoontek commented Sep 27, 2017

@yonahforst I'm interested. I work with RN everyday, and already a collaborator on react-native-i18 :)
I've done https://github.com/react-community/react-native-languages too

@MoOx
Copy link
Collaborator

MoOx commented Sep 27, 2017

I can help too. I think this package is widely used and need more love :)

@Obooman
Copy link

Obooman commented Sep 27, 2017

Hi there, when will this pr be released to npm?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants