Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for breaking iOS header change in RN 0.40.0 #60

Merged
merged 3 commits into from
Feb 3, 2017

Conversation

danieldkim
Copy link
Contributor

For the breaking "iOS native headers moved" change in RN 0.40.0. Addresses facebook/react-native#11725.

@joncursi
Copy link

joncursi commented Jan 9, 2017

👍

For anyone waiting on this, I created a temporary, forked version of this repo here: https://github.com/joncursi/react-native-permissions

Add it to package.json with:

    "react-native-permissions": "git+ssh://git@github.com/joncursi/react-native-permissions.git",

@ericnograles
Copy link

Thanks for the interim fix, @danieldkim and @joncursi, most helpful indeed!

@yonahforst any chance we can get this fix on the release plan? It's a bummer that 0.40 kinda broke the ecosystem. 😞

@lucianomlima
Copy link

@yonahforst please merge this PR.

@yonahforst yonahforst merged commit c11205e into zoontek:master Feb 3, 2017
@yonahforst
Copy link
Collaborator

merged! thank you everyone, and thanks for your patience.

@danieldkim
Copy link
Contributor Author

Thanks @yonahforst!

@joncursi
Copy link

joncursi commented Feb 3, 2017

@yonahforst will you be pushing up a new version to NPM soon, or should I be installing directly from github > master?

@joncursi
Copy link

joncursi commented Feb 9, 2017

0.2.6 is now on NPM, I'd recommend everyone converge back on that as opposed to the forked copies. I may actually end up removing my fork from GitHub since it no longer has added value

@yonahforst
Copy link
Collaborator

please use 0.2.7. there was an android bug in 0.2.6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants