Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to latest meta/config templates #66

Merged
merged 3 commits into from
Sep 4, 2024

Conversation

dataflake
Copy link
Member

@dataflake dataflake commented Sep 2, 2024

There's an exclude for teyit because some tests want to specifically test something teyit would change, like the following test code: FIXED

        dt = DateTime(1)
        <...>
        self.assertTrue(dt == DateTime(1))  # testing __eq__
        self.assertFalse(dt != DateTime(1))  # testing __ne__

@dataflake dataflake requested a review from icemac September 2, 2024 11:53
@dataflake dataflake self-assigned this Sep 2, 2024
@perrinjerome
Copy link
Contributor

Ah I was worried that something like what you describe with teyit #61 (comment) would happen.

How about writing it like this instead, separating the == and != to another line ?

        is_eq = dt == DateTime(1.0)  # testing __eq__
        self.assertTrue(is_eq)

in other places, something like this is checked:

self.assertTrue(str(dt).find('60') < 0)

this seems better:

self.assertNotIn('60', str(dt))

please include the changes from 70d34a4 if you like this.

dataflake and others added 2 commits September 3, 2024 23:41
@dataflake dataflake merged commit e95b160 into master Sep 4, 2024
22 checks passed
@dataflake dataflake deleted the config-with-zope-product-template-acd39fc2 branch September 4, 2024 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants