Serve MessageDialogs and exception views as text/html (4.x) #1082
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
#1081 backported for 4.x |
perrinjerome
force-pushed
the
fix/MessageDialog_asHTML_4.x
branch
2 times, most recently
from
5efc650 to
284111a
Compare
Now that Zope uses text/plain by default, MessageDialogs were served as text/plain. Keep compatibility by returning a special string with `asHTML` method, that ZPublisher.HTTPResponse.HTTPResponse.setBody understands. MessageDialogs are deprecated and do not integrate well in Zope >= 4 ZMI, but they are used in some old products.
perrinjerome
force-pushed
the
fix/MessageDialog_asHTML_4.x
branch
from
284111a to
eb3c8c1
Compare
dataflake
changed the title
dataflake
approved these changes
Dec 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that Zope uses text/plain by default, MessageDialogs were served as text/plain. Keep compatibility by returning a special string with
asHTMLmethod, that ZPublisher.HTTPResponse.HTTPResponse.setBody understands.MessageDialogs are deprecated and do not integrate well in Zope >= 4 ZMI, but they are used in some old products.