Fixed dummy runTest on functional test case. [2.13] #89
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In functional doc tests you can apparently have a test case that has
no runTest method. Until now the Testing package added a dummy
runTest method in that case, and set it to None.
But when this dummy runTest method gets called, you get an error:
Error in test runTest (Testing.ZopeTestCase.ZopeTestCase.FunctionalTestCase)
Traceback (most recent call last):
File ".../lib/python2.7/unittest/case.py", line 329, in run
testMethod()
TypeError: 'NoneType' object is not callable
Simply importing Testing.ZopeTestCase.FunctionalTestCase in a new test
file may be enough to trigger this.
So this has something to do with the order in which tests are found.
I fixed it by making the dummy runTest method callable.
mauritsvanrees
added a commit
to plone/buildout.coredev
that referenced
this pull request
Feb 1, 2017
We have pull request plone/Products.CMFPlone#1921 which needs the merged fix from zopefoundation/Zope#89
mauritsvanrees
added a commit
to plone/buildout.coredev
that referenced
this pull request
Feb 14, 2017
This is only needed for tests. Otherwise you get one failure when running alltests:
'NoneType' object is not callable
File "/usr/lib/python2.7/unittest/case.py", line 329, in run
testMethod()
It was fixed here:
zopefoundation/Zope#89
anand-sd
pushed a commit
to anand-sd/Zope
that referenced
this pull request
Jul 29, 2024
* Enable coveralls Test coverage is not at 100% yet so it should fail this PR. Also enable pip caching since we are installing more deps. Update PyPy versions to latest available for speed and because the old version of PyPy3 can't install newer pip and coverage, etc. Partially addresses zopefoundation#87 * Even newer pypys * Despite the list, pypy-5.6 doesn,t work, it must be 5.6.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In functional doc tests you can apparently have a test case that has no runTest method. Until now the Testing package added a dummy runTest method in that case, and set it to None.
But when this dummy runTest method gets called, you get an error:
Simply importing Testing.ZopeTestCase.FunctionalTestCase in a new test file may be enough to trigger this.
So this has something to do with the order in which tests are found.
I fixed it by making the dummy runTest method callable.
This is related to remarks in #88, which is where I took this commit from.