Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for Python 2.7, 3.5, 3.6 #15

Merged
merged 5 commits into from
Feb 1, 2023

Conversation

dataflake
Copy link
Member

Python 3.11 still fails with a cryptic error coming out of a 🤮 doctest 🤮. I am not sure how to diagnose the issue.

@dataflake dataflake requested review from icemac and d-maurer January 31, 2023 17:08
@dataflake dataflake self-assigned this Jan 31, 2023
Copy link
Contributor

@d-maurer d-maurer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok. But the tailing Python 3.11 test needs to be addressed (apparently, there is a change regarding TemporaryFile).

src/five/formlib/tests/forms.txt Outdated Show resolved Hide resolved
src/five/formlib/tests/test_formlib.py Outdated Show resolved Hide resolved
@icemac
Copy link
Member

icemac commented Feb 1, 2023

@dataflake The Python 3.11 error is python/cpython#90113. See zopefoundation/zope.testbrowser@1bf7361#diff-30acd2539f6fc012a8e0dcf153e8be0f7f514e065f68b2d5291cf518cc45769b as an example how I fixed this in zope.testbrowser.

@dataflake dataflake requested a review from d-maurer February 1, 2023 09:22
@dataflake dataflake marked this pull request as ready for review February 1, 2023 09:22
@dataflake dataflake merged commit c30f7cf into master Feb 1, 2023
@dataflake dataflake deleted the config-with-zope-product-template-a93651c4 branch February 1, 2023 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants