-
Notifications
You must be signed in to change notification settings - Fork 5
processInputs for :records fields #25
Conversation
@jenkins-plone-org please run jobs |
@petschki I dont think our Jenkins CI setup watches this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@jensens yes I saw that ... this package should be moved to /plone I think ... see #3 ... appart from that tests are green but jenkins seems to have a problem with the build, see https://jenkins.plone.org/job/pull-request-5.2/12/ ... and Py3 tests aren't coming up at all (https://jenkins.plone.org/job/pull-request-5.2-3.7/10/console) ... stay tuned here plone/plone.app.caching#49 |
Hm ... jenkins want's to update this PR and has no rights ... I think, in order to get the |
Merged in fork |
Branch: refs/heads/master Date: 2019-04-01T22:28:31+02:00 Author: Peter Mathis (petschki) <peter.mathis@kombinat.at> Commit: plone/plone.app.caching@07fa22e add failing test Files changed: M plone/app/caching/tests/test_integration.py Repository: plone.app.caching Branch: refs/heads/master Date: 2019-04-02T15:40:06+02:00 Author: Peter Mathis (petschki) <peter.mathis@kombinat.at> Commit: plone/plone.app.caching@67bb0f5 fix processing controlpanel form inputs NOTE: this needs zopefoundation/plone.z3cform#25 Files changed: A news/48.bugfix M plone/app/caching/browser/controlpanel.py M setup.py Repository: plone.app.caching Branch: refs/heads/master Date: 2019-04-02T15:42:39+02:00 Author: Peter Mathis (petschki) <peter.mathis@kombinat.at> Commit: plone/plone.app.caching@15bd18b typo in setup Files changed: M setup.py Repository: plone.app.caching Branch: refs/heads/master Date: 2019-04-02T15:46:15+02:00 Author: Peter Mathis (petschki) <peter.mathis@kombinat.at> Commit: plone/plone.app.caching@ac3eeae fix version pin Files changed: M setup.py Repository: plone.app.caching Branch: refs/heads/master Date: 2019-04-04T20:25:39+02:00 Author: Peter Mathis (petschki) <peter.mathis@kombinat.at> Commit: plone/plone.app.caching@9a879fa platform dependent version pin Files changed: M setup.py Repository: plone.app.caching Branch: refs/heads/master Date: 2019-04-05T09:19:24+02:00 Author: Philip Bauer (pbauer) <bauer@starzel.de> Commit: plone/plone.app.caching@c6302d3 Merge pull request #49 from plone/issue_48 Fix controlpanel for Python 3 Files changed: A news/48.bugfix M plone/app/caching/browser/controlpanel.py M plone/app/caching/tests/test_integration.py M setup.py
In order to have a feature complete form field processing, let's take
:record[s]
fields into account ... see #24