Skip to content
This repository has been archived by the owner on Apr 9, 2019. It is now read-only.

processInputs for :records fields #25

Closed
wants to merge 4 commits into from
Closed

processInputs for :records fields #25

wants to merge 4 commits into from

Conversation

petschki
Copy link
Contributor

@petschki petschki commented Apr 2, 2019

In order to have a feature complete form field processing, let's take :record[s] fields into account ... see #24

@petschki
Copy link
Contributor Author

petschki commented Apr 2, 2019

@jenkins-plone-org please run jobs

petschki added a commit to plone/plone.app.caching that referenced this pull request Apr 2, 2019
@jensens
Copy link
Member

jensens commented Apr 3, 2019

@petschki I dont think our Jenkins CI setup watches this.

Copy link
Member

@jensens jensens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@petschki
Copy link
Contributor Author

petschki commented Apr 3, 2019

@jensens yes I saw that ... this package should be moved to /plone I think ... see #3 ... appart from that tests are green but jenkins seems to have a problem with the build, see https://jenkins.plone.org/job/pull-request-5.2/12/ ... and Py3 tests aren't coming up at all (https://jenkins.plone.org/job/pull-request-5.2-3.7/10/console) ... stay tuned here plone/plone.app.caching#49

@petschki
Copy link
Contributor Author

petschki commented Apr 3, 2019

Hm ... jenkins want's to update this PR and has no rights ... I think, in order to get the plone.app.caching PR green (due to the version pin here https://github.com/plone/plone.app.caching/pull/49/files#diff-2eeaed663bd0d25b7e608891384b7298R58) we should merge and release this ... @jensens what do you think?

@petschki petschki removed the testing label Apr 3, 2019
@petschki
Copy link
Contributor Author

petschki commented Apr 4, 2019

Merged in fork

@petschki petschki closed this Apr 4, 2019
mister-roboto pushed a commit to plone/buildout.coredev that referenced this pull request Apr 5, 2019
Branch: refs/heads/master
Date: 2019-04-01T22:28:31+02:00
Author: Peter Mathis (petschki) <peter.mathis@kombinat.at>
Commit: plone/plone.app.caching@07fa22e

add failing test

Files changed:
M plone/app/caching/tests/test_integration.py
Repository: plone.app.caching

Branch: refs/heads/master
Date: 2019-04-02T15:40:06+02:00
Author: Peter Mathis (petschki) <peter.mathis@kombinat.at>
Commit: plone/plone.app.caching@67bb0f5

fix processing controlpanel form inputs

NOTE: this needs zopefoundation/plone.z3cform#25

Files changed:
A news/48.bugfix
M plone/app/caching/browser/controlpanel.py
M setup.py
Repository: plone.app.caching

Branch: refs/heads/master
Date: 2019-04-02T15:42:39+02:00
Author: Peter Mathis (petschki) <peter.mathis@kombinat.at>
Commit: plone/plone.app.caching@15bd18b

typo in setup

Files changed:
M setup.py
Repository: plone.app.caching

Branch: refs/heads/master
Date: 2019-04-02T15:46:15+02:00
Author: Peter Mathis (petschki) <peter.mathis@kombinat.at>
Commit: plone/plone.app.caching@ac3eeae

fix version pin

Files changed:
M setup.py
Repository: plone.app.caching

Branch: refs/heads/master
Date: 2019-04-04T20:25:39+02:00
Author: Peter Mathis (petschki) <peter.mathis@kombinat.at>
Commit: plone/plone.app.caching@9a879fa

platform dependent version pin

Files changed:
M setup.py
Repository: plone.app.caching

Branch: refs/heads/master
Date: 2019-04-05T09:19:24+02:00
Author: Philip Bauer (pbauer) <bauer@starzel.de>
Commit: plone/plone.app.caching@c6302d3

Merge pull request #49 from plone/issue_48

Fix controlpanel for Python 3

Files changed:
A news/48.bugfix
M plone/app/caching/browser/controlpanel.py
M plone/app/caching/tests/test_integration.py
M setup.py
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants