Skip to content
This repository has been archived by the owner on Sep 8, 2020. It is now read-only.

Use new Python 2.6/3.x compatible exception syntax #1

Merged
merged 2 commits into from
Nov 21, 2019

Conversation

stevepiercy
Copy link
Contributor

No description provided.

Copy link
Member

@jamadden jamadden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! That looks good to me, and it’s a simple enough standalone change that I don’t think it needs extra tests or changes to CI. There aren’t even any existing classifiers to worry about, though a note in CHANGES.txt might be nice.

It was once the policy of this organization that any substantial changes that could be considered copyrighted only be accepted from someone who had signed the contributor agreement. Simple changes could bypass that check. Signing the agreement would confer membership in the organization and members can (were expected to, after approval) merge their own PRs. IANAL, but this change would seem to be simple enough to bypass the requirement for membership.

However, I suspect that there are new governance structures in place with the subsuming of the Zope foundation by the Plone foundation, and I don’t know what the rules are. Perhaps someone who does can comment? I used to ask @tseaver about this.

@stevepiercy
Copy link
Contributor Author

I will push another commit for a note in CHANGES.txt.

FTR, I have no problem signing an agreement under Zope, and I have signed the Plone Contributor Agreement. Please let me know if you need me to sign something.

@stevepiercy
Copy link
Contributor Author

Commit to CHANGES.txt pushed.

@ableeb
Copy link

ableeb commented Nov 20, 2019

@stevepiercy the Zope contributor agreement explained here:
https://community.plone.org/t/becoming-a-contributor-updated-version/8550. Technically, you should sign it before any contribution is accepted. That said, Plone enforces this with a 'bot, which I don't think is set up for Zope.

@stevepiercy
Copy link
Contributor Author

@ableeb Sent!

@stevepiercy
Copy link
Contributor Author

Invitation to zopefoundation accepted.

What's the next step? Do I merge this PR myself or someone else?

How does a release get made? I'm eager to test it out in a deployment via Ansible and the Plone server playbook.

@jugmac00 jugmac00 self-requested a review November 20, 2019 22:48
Copy link
Member

@jugmac00 jugmac00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@jugmac00
Copy link
Member

Concerning the merge - @jamadden worte:

Signing the agreement would confer membership in the organization and members can (were expected to, after approval) merge their own PRs.

So, basically you need the agreement signed (check), and you need a positive review (approval) from another Zope contributor (check), then you can and should merge yourself.

@jugmac00
Copy link
Member

Concerning the packaging process...

Having a look at https://pypi.org/project/zc.monitor/ ... hm, I am not sure who of them is still active.

Pinging @jimfulton @benji-york @freddrake @garyposter

Maybe you could give @mgedmin @jamadden @icemac or @dataflake access to this PyPi package?

Thank you!

@stevepiercy stevepiercy merged commit fc17b8d into zopefoundation:master Nov 21, 2019
@stevepiercy stevepiercy deleted the patch-1 branch November 21, 2019 01:16
@benji-york
Copy link
Contributor

Thanks for the ping; I've given @mgedmin and @dataflake Owner access to the PyPI repo.

@stevepiercy
Copy link
Contributor Author

@mgedmin or @dataflake would you please cut a release for this merged PR? I'd like to test it out this US holiday weekend. Thank you!

@dataflake
Copy link
Member

I have no idea why I am listed as maintainer on PyPI, I have nothing to do with this package. I'll defer to @mgedmin

@icemac
Copy link
Member

icemac commented Dec 6, 2019

@mgedmin As this change is not yet released, I'd like to volunteer to make this release but I (icemac) would need PyPI rights to do so.

@benji-york
Copy link
Contributor

[...] but I (icemac) would need PyPI rights to do so.

Done!

@icemac icemac mentioned this pull request Dec 6, 2019
@icemac
Copy link
Member

icemac commented Dec 6, 2019

I just released https://pypi.org/project/zc.monitor/0.4.0.post1/.
I do not have much hope that it runs on Python 3 as it needs zc.ngi which is currently Python-2-only.

@icemac
Copy link
Member

icemac commented Dec 6, 2019

For details see #3.

@mgedmin
Copy link
Member

mgedmin commented Dec 9, 2019

(Sorry, I was AFK for a couple of weeks for life reasons.)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants