-
Notifications
You must be signed in to change notification settings - Fork 4
Use new Python 2.6/3.x compatible exception syntax #1
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! That looks good to me, and it’s a simple enough standalone change that I don’t think it needs extra tests or changes to CI. There aren’t even any existing classifiers to worry about, though a note in CHANGES.txt might be nice.
It was once the policy of this organization that any substantial changes that could be considered copyrighted only be accepted from someone who had signed the contributor agreement. Simple changes could bypass that check. Signing the agreement would confer membership in the organization and members can (were expected to, after approval) merge their own PRs. IANAL, but this change would seem to be simple enough to bypass the requirement for membership.
However, I suspect that there are new governance structures in place with the subsuming of the Zope foundation by the Plone foundation, and I don’t know what the rules are. Perhaps someone who does can comment? I used to ask @tseaver about this.
I will push another commit for a note in CHANGES.txt. FTR, I have no problem signing an agreement under Zope, and I have signed the Plone Contributor Agreement. Please let me know if you need me to sign something. |
Commit to CHANGES.txt pushed. |
@stevepiercy the Zope contributor agreement explained here: |
@ableeb Sent! |
Invitation to zopefoundation accepted. What's the next step? Do I merge this PR myself or someone else? How does a release get made? I'm eager to test it out in a deployment via Ansible and the Plone server playbook. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
Concerning the merge - @jamadden worte:
So, basically you need the agreement signed (check), and you need a positive review (approval) from another Zope contributor (check), then you can and should merge yourself. |
Concerning the packaging process... Having a look at https://pypi.org/project/zc.monitor/ ... hm, I am not sure who of them is still active. Pinging @jimfulton @benji-york @freddrake @garyposter Maybe you could give @mgedmin @jamadden @icemac or @dataflake access to this PyPi package? Thank you! |
Thanks for the ping; I've given @mgedmin and @dataflake Owner access to the PyPI repo. |
@mgedmin or @dataflake would you please cut a release for this merged PR? I'd like to test it out this US holiday weekend. Thank you! |
I have no idea why I am listed as maintainer on PyPI, I have nothing to do with this package. I'll defer to @mgedmin |
@mgedmin As this change is not yet released, I'd like to volunteer to make this release but I ( |
Done! |
I just released https://pypi.org/project/zc.monitor/0.4.0.post1/. |
For details see #3. |
(Sorry, I was AFK for a couple of weeks for life reasons.) |
No description provided.