Skip to content
This repository has been archived by the owner on May 13, 2020. It is now read-only.

support IPv6 #1

Merged
merged 4 commits into from
Aug 31, 2017
Merged

support IPv6 #1

merged 4 commits into from
Aug 31, 2017

Conversation

gotcha
Copy link
Member

@gotcha gotcha commented Aug 31, 2017

No description provided.

@gotcha gotcha requested a review from jimfulton August 31, 2017 09:52
@jimfulton
Copy link
Member

Thanks for doing this!

@jimfulton
Copy link
Member

I'm going to add travis later before merging this.

@gotcha
Copy link
Member Author

gotcha commented Aug 31, 2017

Travis is already on. And tests pass.

@gotcha
Copy link
Member Author

gotcha commented Aug 31, 2017

@jimfulton I wonder if there is a need to expand tests to run under IPv6. Or if we trust underlying infrastructure.

@jimfulton
Copy link
Member

Oops

@jimfulton jimfulton merged commit c20f873 into zopefoundation:master Aug 31, 2017
@gotcha
Copy link
Member Author

gotcha commented Aug 31, 2017

@jimfulton Would you mind giving me permission on PyPI to release ? (userid gotcha)

@jimfulton
Copy link
Member

Released 2.1.0. Thanks again.

@jimfulton
Copy link
Member

I also made you a pypi owner.

@gotcha
Copy link
Member Author

gotcha commented Aug 31, 2017

Thanks

@jimfulton
Copy link
Member

FWIW, I find parts of asyncio(/trollius) to be very similar to ngi. Working on the networking for ZEO 5 was very similar to working with ngi. I thought of making an asyncio backend for ngi, but decided it would be better, at least for new code, to just use asyncio.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants