Activate GH actions. #7
Conversation
There was a problem hiding this comment.
LGTM.
There's a Travis badge in README.rst. It should be replaced with some GHA badge. I'm sure those exist, as I've seen one in https://eli.thegreenplace.net/2020/github-actions-first-impressions/ (but that page embeds the SVG instead of linking to it).
| - name: Test | ||
| run: tox -e {{ matrix.env || 'py'}} | ||
| run: tox -e ${{ matrix.config[2] }} |
There was a problem hiding this comment.
The config matrix seems very repetetive, which gives me an idea. Could we do matrix.config[2] || 'py' here and fill the last column with null or "" or perhaps even omit it entirely?
What sort of expressions are allowed inside ${{ ... }}?
There was a problem hiding this comment.
You are right two of the three values in the matrix are always the same. But the columns differ.
I see no way to omit the last column. Using null values there seems to make the workflow more complex as the default is used outside the matrix and would require to document it at least.
| # Generated from: | ||
| # https://github.com/zopefoundation/meta/tree/master/config/pure-python | ||
| language: python | ||
| python: |
There was a problem hiding this comment.
Maybe let's keep it for a bit longer, while we evaluate GitHub actions? It's not currently broken, is it?
There was a problem hiding this comment.
I removed it in the PR so not each try to get it running runs on TravisCI using up our credits over there.
There was a problem hiding this comment.
According to https://travis-ci.com/github/zopefoundation?tab=insights&timeInterval=week we used more than 1,000 minutes last week. So IMHO we should not eat up the Travis credits for repositories migrated to GHA.
| - name: Test | ||
| run: tox -e {{ matrix.env || 'py'}} | ||
| run: tox -e ${{ matrix.config[2] }} |
There was a problem hiding this comment.
You are right two of the three values in the matrix are always the same. But the columns differ.
I see no way to omit the last column. Using null values there seems to make the workflow more complex as the default is used outside the matrix and would require to document it at least.
| # Generated from: | ||
| # https://github.com/zopefoundation/meta/tree/master/config/pure-python | ||
| language: python | ||
| python: |
There was a problem hiding this comment.
I removed it in the PR so not each try to get it running runs on TravisCI using up our credits over there.
Activate GH actions with the following features: