Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make PersistentAdapterRegistry use PersistentMapping/PersistentList #53

Merged
merged 2 commits into from
Mar 18, 2021

Conversation

jamadden
Copy link
Member

Fixes #51.

This won't actually run on CI until zope.interface 5.3 is released, but can be tested locally, so I'm opening as a draft for comments.

The first commit gets basic GHA up and running, pending a better solution to #52. It could be moved to a separate PR.

@jamadden
Copy link
Member Author

Please let me handle updating this branch.

@dataflake
Copy link
Member

Apologies, I rebased on the new master

@jamadden
Copy link
Member Author

It looks like you had merged the new master, so there were a whole bunch of commits on this branch.

I dropped the first commit from this branch and then rebased, with the end result that there's only one commit here.

@dataflake
Copy link
Member

I did try a rebase, but my knowledge of rebasing is lacking. I always end up with a situation where the sandbox wants me to pull and push changes after that merge.

@jamadden
Copy link
Member Author

My rebasing skills are terrible too! Then I discovered magit which makes a process like this much less painful.

@dataflake
Copy link
Member

Emacs, booo!  😂

@jamadden
Copy link
Member Author

With zope.interface 5.3a1, all tests pass.

@jamadden
Copy link
Member Author

Thank you! Once this goes green again (a conflict had to be resolved), I'll merge.

I'd like to release 5.0 soon-ish. Of the remaining open issues, #10 is both a potentially (but unlikely) breaking change, and easy to do. Any thoughts on that one? Like I said in the issue, I'm not a user of those APIs so I'm not sure what the impact would be, but I do heavily use z3c.baseregistry.

@jamadden jamadden merged commit 950b4a4 into master Mar 18, 2021
@jamadden jamadden deleted the issue51 branch March 18, 2021 18:00
@dataflake
Copy link
Member

As far as I am concerned you can release 5.0 anytime you like. Zope and Plone are using pinned versions so there's time to test.

@dataflake
Copy link
Member

P.S.: #10 sounds fine to attack at the same time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make PersistentAdapterRegistry use PersistentMapping and PersistentList instead of dict and tuple
2 participants