-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make PersistentAdapterRegistry use PersistentMapping/PersistentList #53
Conversation
Please let me handle updating this branch. |
Apologies, I rebased on the new |
It looks like you had merged the new master, so there were a whole bunch of commits on this branch. I dropped the first commit from this branch and then rebased, with the end result that there's only one commit here. |
I did try a rebase, but my knowledge of rebasing is lacking. I always end up with a situation where the sandbox wants me to pull and push changes after that merge. |
My rebasing skills are terrible too! Then I discovered magit which makes a process like this much less painful. |
Emacs, booo! 😂 |
With zope.interface 5.3a1, all tests pass. |
…ith zope.interface 5.3+ Fixes #51
Thank you! Once this goes green again (a conflict had to be resolved), I'll merge. I'd like to release 5.0 soon-ish. Of the remaining open issues, #10 is both a potentially (but unlikely) breaking change, and easy to do. Any thoughts on that one? Like I said in the issue, I'm not a user of those APIs so I'm not sure what the impact would be, but I do heavily use z3c.baseregistry. |
As far as I am concerned you can release 5.0 anytime you like. Zope and Plone are using pinned versions so there's time to test. |
P.S.: #10 sounds fine to attack at the same time. |
Fixes #51.
This won't actually run on CI until zope.interface 5.3 is released, but can be tested locally, so I'm opening as a draft for comments.
The first commit gets basic GHA up and running, pending a better solution to #52. It could be moved to a separate PR.