Config with pure python #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With `--ignore W690,E711,E721 --aggressive`
The old way worked, but gave a linting error because unicode is not defined.
This is not called during the tests, and this results in less coverage.
We had 100% test coverage previously, but this dropped to around 99.11 percent when using the new default in tox.ini: ``` [coverage:run] branch = True ``` With branch=False, the coverage would be back at 100 percent, but I don't see a way to configure this in meta.toml, and it may be better to see the actual coverage. We should add more tests to cover the untested branches. For now, we lower our expectations.
I mixed up Python 2 and 3 in the try/except comment. Co-authored-by: Michael Howitz <mh@gocept.com>
Merged
icemac
approved these changes
Sep 6, 2021
|
Thank you for this PR. 😃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With autopep8 now.