Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'unknown' monitor threshold field #139

Merged
merged 1 commit into from
Jan 16, 2018
Merged

Add 'unknown' monitor threshold field #139

merged 1 commit into from
Jan 16, 2018

Conversation

visciang
Copy link
Contributor

This PR adds support for Datadog monitor threshold field.

Giovanni

@ojongerius
Copy link
Collaborator

ojongerius commented Jan 15, 2018

LGTM! I am wondering what the unknown threshold does. I can't find a reference to it in regards to monitors at https://docs.datadoghq.com/api/?lang=bash#get-a-monitor-s-details @visciang what is it supposed to provide?

@entropiae
Copy link

It looks like it isn't in the documentation (we are opening a PR for the DD API documentation); it set the threshold after which a service check in unknown status trigger a monitor; it's the grey slider in the attached screenshot.
Here there is the documentation service-check side: https://docs.datadoghq.com/agent/agent_checks/#sending-service-checks

screenshot from 2018-01-16 09-13-17

@ojongerius ojongerius merged commit 8d504de into zorkian:master Jan 16, 2018
@ojongerius
Copy link
Collaborator

Thanks for the work and feedback!

@entropiae
Copy link

Thank you too 😃

@visciang
Copy link
Contributor Author

visciang commented Jan 16, 2018

@ojongerius please, could you tag a new release, so that I can reference it in the PR I'm opening to terraform-providers/terraform-provider-datadog?

Thank you

@ghost
Copy link

ghost commented Jan 16, 2018

@visciang I tagged this commit as v2.8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants