-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix type issue for threshold in screenboard rule #169
Conversation
I'm having trouble finding any documentation about an "uptime" screen widget, so any testing I've been doing to validate this has been based on the code in the integration tests. Do you have any doc links you could share to make this a bit easier? |
@nyanshak Actually the |
The reason for using I just tested against the screenboard API to make a screenboard with uptime widget with thresholds:
I'm able to send thresholds as strings (and Datadog subsequently sends them back as strings). Using float64 as the type results in errors somewhat like this:
Looking back, I believe this is originally the reason we started using Besides that issue with the type, I'm happy to merge this. |
Because of a type issue, we could not submit thresholds such as
99.9
for rules in the uptime widget.This PR fixes that.