Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change GraphDefinition.Precision type #179

Merged
merged 1 commit into from
Oct 11, 2018
Merged

Change GraphDefinition.Precision type #179

merged 1 commit into from
Oct 11, 2018

Conversation

nyanshak
Copy link
Collaborator

  • Datadog's API will accept / return the following types for precision
    (query value widget on timeboards / screenboards): int (e.g., 4), string
    with integer inside (e.g., "4"), or the specific string "*" (meaning
    full precision). This commit adds support for the integer case.

* Datadog's API will accept / return the following types for precision
(query value widget on timeboards / screenboards): int (e.g., 4), string
with integer inside (e.g., "4"), or the specific string "*" (meaning
full precision). This commit adds support for the integer case.
Copy link
Collaborator

@ojongerius ojongerius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@ojongerius
Copy link
Collaborator

ojongerius commented Oct 11, 2018

@nyanshak are you good to merge and cut a release? If so that release would include this change and #178

@nyanshak nyanshak merged commit da6dade into zorkian:master Oct 11, 2018
@nyanshak
Copy link
Collaborator Author

Cheers @ojongerius, going to cut a release with this and #178

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants