Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The 1.0.1 release broke a test for us #174

Closed
timthelion opened this issue Oct 2, 2019 · 3 comments
Closed

The 1.0.1 release broke a test for us #174

timthelion opened this issue Oct 2, 2019 · 3 comments

Comments

@timthelion
Copy link

Downgrading to 0.0.8 fixes it.

test_dpnk_registration_company_admin_undecided (dpnk.test.test_views.RegistrationMixinTests) ... ERROR Internal Server Error: /jizdy
Traceback (most recent call last):
  File "/usr/local/lib/python3.6/site-packages/django/core/handlers/exception.py", line 35, in inner
    response = get_response(request)
  File "/usr/local/lib/python3.6/site-packages/django/core/handlers/base.py", line 158, in _get_response
    response = self.process_exception_by_middleware(e, request)
  File "/usr/local/lib/python3.6/site-packages/django/core/handlers/base.py", line 156, in _get_response
    response = response.render()
  File "/usr/local/lib/python3.6/site-packages/django/template/response.py", line 106, in render
    self.content = self.rendered_content
  File "/usr/local/lib/python3.6/site-packages/django/template/response.py", line 83, in rendered_content
    content = template.render(context, self._request)
  File "/usr/local/lib/python3.6/site-packages/django/template/backends/django.py", line 61, in render
    return self.template.render(context)
  File "/usr/local/lib/python3.6/site-packages/django/template/base.py", line 175, in render
    return self._render(context)
  File "/usr/local/lib/python3.6/site-packages/django/test/utils.py", line 98, in instrumented_test_render
    return self.nodelist.render(context)
  File "/usr/local/lib/python3.6/site-packages/django/template/base.py", line 943, in render
    bit = node.render_annotated(context)
  File "/usr/local/lib/python3.6/site-packages/django/template/base.py", line 910, in render_annotated
    return self.render(context)
  File "/usr/local/lib/python3.6/site-packages/django/template/loader_tags.py", line 155, in render
    return compiled_parent._render(context)
  File "/usr/local/lib/python3.6/site-packages/django/test/utils.py", line 98, in instrumented_test_render
    return self.nodelist.render(context)
  File "/usr/local/lib/python3.6/site-packages/django/template/base.py", line 943, in render
    bit = node.render_annotated(context)
  File "/usr/local/lib/python3.6/site-packages/django/template/base.py", line 910, in render_annotated
    return self.render(context)
  File "/usr/local/lib/python3.6/site-packages/django/template/loader_tags.py", line 155, in render
    return compiled_parent._render(context)
  File "/usr/local/lib/python3.6/site-packages/django/test/utils.py", line 98, in instrumented_test_render
    return self.nodelist.render(context)
  File "/usr/local/lib/python3.6/site-packages/django/template/base.py", line 943, in render
    bit = node.render_annotated(context)
  File "/usr/local/lib/python3.6/site-packages/django/template/base.py", line 910, in render_annotated
    return self.render(context)
  File "/usr/local/lib/python3.6/site-packages/django/template/loader_tags.py", line 155, in render
    return compiled_parent._render(context)
  File "/usr/local/lib/python3.6/site-packages/django/test/utils.py", line 98, in instrumented_test_render
    return self.nodelist.render(context)
  File "/usr/local/lib/python3.6/site-packages/django/template/base.py", line 943, in render
    bit = node.render_annotated(context)
  File "/usr/local/lib/python3.6/site-packages/django/template/base.py", line 910, in render_annotated
    return self.render(context)
  File "/usr/local/lib/python3.6/site-packages/django/template/loader_tags.py", line 67, in render
    result = block.nodelist.render(context)
  File "/usr/local/lib/python3.6/site-packages/django/template/base.py", line 943, in render
    bit = node.render_annotated(context)
  File "/usr/local/lib/python3.6/site-packages/django/template/base.py", line 910, in render_annotated
    return self.render(context)
  File "/usr/local/lib/python3.6/site-packages/django/template/loader_tags.py", line 67, in render
    result = block.nodelist.render(context)
  File "/usr/local/lib/python3.6/site-packages/django/template/base.py", line 943, in render
    bit = node.render_annotated(context)
  File "/usr/local/lib/python3.6/site-packages/django/template/base.py", line 910, in render_annotated
    return self.render(context)
  File "/usr/local/lib/python3.6/site-packages/django/template/base.py", line 993, in render
    output = self.filter_expression.resolve(context)
  File "/usr/local/lib/python3.6/site-packages/django/template/base.py", line 676, in resolve
    obj = self.var.resolve(context)
  File "/usr/local/lib/python3.6/site-packages/django/template/base.py", line 802, in resolve
    value = self._resolve_lookup(context)
  File "/usr/local/lib/python3.6/site-packages/django/template/base.py", line 864, in _resolve_lookup
    current = current()
  File "/usr/local/lib/python3.6/site-packages/django/template/loader_tags.py", line 81, in super
    return mark_safe(self.render(self.context))
  File "/usr/local/lib/python3.6/site-packages/django/template/loader_tags.py", line 67, in render
    result = block.nodelist.render(context)
  File "/usr/local/lib/python3.6/site-packages/django/template/base.py", line 943, in render
    bit = node.render_annotated(context)
  File "/usr/local/lib/python3.6/site-packages/django/template/base.py", line 910, in render_annotated
    return self.render(context)
  File "/usr/local/lib/python3.6/site-packages/django/template/base.py", line 993, in render
    output = self.filter_expression.resolve(context)
  File "/usr/local/lib/python3.6/site-packages/django/template/base.py", line 676, in resolve
    obj = self.var.resolve(context)
  File "/usr/local/lib/python3.6/site-packages/django/template/base.py", line 802, in resolve
    value = self._resolve_lookup(context)
  File "/usr/local/lib/python3.6/site-packages/django/template/base.py", line 864, in _resolve_lookup
    current = current()
  File "/usr/local/lib/python3.6/site-packages/django/template/loader_tags.py", line 81, in super
    return mark_safe(self.render(self.context))
  File "/usr/local/lib/python3.6/site-packages/django/template/loader_tags.py", line 67, in render
    result = block.nodelist.render(context)
  File "/usr/local/lib/python3.6/site-packages/django/template/base.py", line 943, in render
    bit = node.render_annotated(context)
  File "/usr/local/lib/python3.6/site-packages/django/template/base.py", line 910, in render_annotated
    return self.render(context)
  File "/usr/local/lib/python3.6/site-packages/django/template/defaulttags.py", line 314, in render
    return nodelist.render(context)
  File "/usr/local/lib/python3.6/site-packages/django/template/base.py", line 943, in render
    bit = node.render_annotated(context)
  File "/usr/local/lib/python3.6/site-packages/django/template/base.py", line 910, in render_annotated
    return self.render(context)
  File "/usr/local/lib/python3.6/site-packages/django/template/loader_tags.py", line 67, in render
    result = block.nodelist.render(context)
  File "/usr/local/lib/python3.6/site-packages/django/template/base.py", line 943, in render
    bit = node.render_annotated(context)
  File "/usr/local/lib/python3.6/site-packages/django/template/base.py", line 910, in render_annotated
    return self.render(context)
  File "/usr/local/lib/python3.6/site-packages/django/template/loader_tags.py", line 67, in render
    result = block.nodelist.render(context)
  File "/usr/local/lib/python3.6/site-packages/django/template/base.py", line 943, in render
    bit = node.render_annotated(context)
  File "/usr/local/lib/python3.6/site-packages/django/template/base.py", line 910, in render_annotated
    return self.render(context)
  File "/usr/local/lib/python3.6/site-packages/django/template/loader_tags.py", line 67, in render
    result = block.nodelist.render(context)
  File "/usr/local/lib/python3.6/site-packages/django/template/base.py", line 943, in render
    bit = node.render_annotated(context)
  File "/usr/local/lib/python3.6/site-packages/django/template/base.py", line 910, in render_annotated
    return self.render(context)
  File "/usr/local/lib/python3.6/site-packages/django/template/loader_tags.py", line 194, in render
    return template.render(context)
  File "/usr/local/lib/python3.6/site-packages/django/template/base.py", line 177, in render
    return self._render(context)
  File "/usr/local/lib/python3.6/site-packages/django/test/utils.py", line 98, in instrumented_test_render
    return self.nodelist.render(context)
  File "/usr/local/lib/python3.6/site-packages/django/template/base.py", line 943, in render
    bit = node.render_annotated(context)
  File "/usr/local/lib/python3.6/site-packages/django/template/base.py", line 910, in render_annotated
    return self.render(context)
  File "/usr/local/lib/python3.6/site-packages/django/template/defaulttags.py", line 314, in render
    return nodelist.render(context)
  File "/usr/local/lib/python3.6/site-packages/django/template/base.py", line 943, in render
    bit = node.render_annotated(context)
  File "/usr/local/lib/python3.6/site-packages/django/template/base.py", line 910, in render_annotated
    return self.render(context)
  File "/usr/local/lib/python3.6/site-packages/django/template/defaulttags.py", line 211, in render
    nodelist.append(node.render_annotated(context))
  File "/usr/local/lib/python3.6/site-packages/django/template/base.py", line 910, in render_annotated
    return self.render(context)
  File "/usr/local/lib/python3.6/site-packages/django/template/library.py", line 192, in render
    output = self.func(*resolved_args, **resolved_kwargs)
  File "/usr/local/lib/python3.6/site-packages/bootstrap4/templatetags/bootstrap4.py", line 454, in bootstrap_form
    return render_form(*args, **kwargs)
  File "/usr/local/lib/python3.6/site-packages/bootstrap4/forms.py", line 37, in render_form
    return renderer_cls(form, **kwargs).render()
  File "/usr/local/lib/python3.6/site-packages/bootstrap4/renderers.py", line 84, in render
    return mark_safe(self._render())
  File "/usr/local/lib/python3.6/site-packages/bootstrap4/renderers.py", line 201, in _render
    return self.render_errors(self.alert_error_type) + self.render_fields()
  File "/usr/local/lib/python3.6/site-packages/bootstrap4/renderers.py", line 171, in render_fields
    bound_css_class=self.bound_css_class,
  File "/usr/local/lib/python3.6/site-packages/bootstrap4/forms.py", line 49, in render_field
    return renderer_cls(field, **kwargs).render()
  File "/usr/local/lib/python3.6/site-packages/bootstrap4/renderers.py", line 84, in render
    return mark_safe(self._render())
  File "/usr/local/lib/python3.6/site-packages/bootstrap4/renderers.py", line 510, in _render
    html = self.post_widget_render(html)
  File "/usr/local/lib/python3.6/site-packages/bootstrap4/renderers.py", line 356, in post_widget_render
    html = self.list_to_class(html, "radio radio-success")
  File "/usr/local/lib/python3.6/site-packages/bootstrap4/renderers.py", line 336, in list_to_class
    label.input.attrs["class"] = label.input.attrs.get("class", []) + ["form-check-input"]
AttributeError: 'NoneType' object has no attribute 'attrs'

https://circleci.com/gh/auto-mat/do-prace-na-kole/636?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link
timthelion added a commit to auto-mat/do-prace-na-kole that referenced this issue Oct 2, 2019
@timthelion
Downgrade django-bootstrap4
a33f2a0 
zostera/django-bootstrap4#174
@jieter
Copy link
Member

jieter commented Oct 3, 2019

annotate points to commit aabd551

@smallreflection
Copy link

Having the same issue here.

dyve added a commit that referenced this issue Dec 6, 2019
@dyve
Do not assume input within label (fixes #174)
d1bcefc
dyve added a commit that referenced this issue Dec 6, 2019
@dyve
Improved fix for #174 and #181
b017da6
dyve added a commit that referenced this issue Dec 6, 2019
@dyve
Prepare release 1.1.0
23fdb82 
- Update default Bootstrap to v4.3.1
- Add support for Python 3.8, Django 3 and Django master
- Switch to Django `manage.py` for test running
- Update Makefile commands
- Update tox configuration
- Use correct license (BSD-3-Clause)
- Fix typo's in docstrings
- Update Travis configuration
- Drop MANIFEST.in, use setuptools_scm
- Stop using _version.py, use git tags for versioning
- Fixed issues with labels and input (#174 and #181)
@dyve dyve mentioned this issue Dec 6, 2019
Merged
dyve added a commit that referenced this issue Dec 7, 2019
@dyve
Prepare release 1.1.0 (#185)
bb845a4 
* Prepare release 1.1.0

- Update default Bootstrap to v4.3.1
- Add support for Python 3.8, Django 3 and Django master
- Switch to Django `manage.py` for test running
- Update Makefile commands
- Update tox configuration
- Use correct license (BSD-3-Clause)
- Fix typo's in docstrings
- Update Travis configuration
- Drop MANIFEST.in, use setuptools_scm
- Stop using _version.py, use git tags for versioning
- Fixed issues with labels and input (#174 and #181)
@dyve
Copy link
Member

dyve commented Dec 10, 2019

This was fixed in v1.1.0

@dyve dyve closed this as completed Dec 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@dyve @timthelion @jieter @smallreflection