Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CheckboxSelectMultiple on Django>4 #672

Merged
merged 2 commits into from
Jan 23, 2024
Merged

Fix CheckboxSelectMultiple on Django>4 #672

merged 2 commits into from
Jan 23, 2024

Conversation

heso
Copy link
Contributor

@heso heso commented Jan 21, 2024 •
edited
Loading

In Django >=4.2 CheckboxSelectMultiple is subclass of RadioSelect.

Therefore this part is unreachable.
The easyest fix is swap if.

image

@dyve
Copy link
Member

dyve commented Jan 22, 2024

Thanks, can you add a test for behavior in Django < 4.2 and Django >= 4.2? Then the PR is complete.

@heso
Copy link
Contributor Author

heso commented Jan 22, 2024

added missing tests for CheckboxSelectMultiple,
Will tested with various Django versions with tests_matrix via Github-CI.

Tox tests passed.

@dyve
Copy link
Member

dyve commented Jan 23, 2024

Thanks!

@dyve dyve merged commit 72588fe into zostera:main Jan 23, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@heso @dyve