Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Field valid and invalid custom classes #739

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

suspiciousRaccoon
Copy link

Adds 2 new parameters to the field renderer to allow overriding the default valid and invalid classes

Fixes #738

@dyve
Copy link
Member

dyve commented Dec 21, 2024

Thank you for the pull request!

Docs: https://getbootstrap.com/docs/5.0/forms/validation/

Looks like Bootstrap 5 defaults to pseudo classes. Let's check the standards before committing to an alternative.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 12422610075

Details

  • 16 of 16 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 97.886%

Totals Coverage Status
Change from base Build 12348252146: 0.02%
Covered Lines: 1421
Relevant Lines: 1442

💛 - Coveralls

@TohidN
Copy link

TohidN commented Dec 24, 2024

Looks like Bootstrap 5 defaults to pseudo classes. Let's check the standards before committing to an alternative.

while Bootstrap standard is to use .is-invalid and .is-valid classes, this pull provides a roundabout solution for disabling validation for bound forms, as mentioned in #738

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Customizing validation on specific fields or form
4 participants