Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

拆 XPI 包读取和校验插件信息 #41

Closed
northword opened this issue Nov 1, 2023 · 5 comments · Fixed by #89
Closed

拆 XPI 包读取和校验插件信息 #41

northword opened this issue Nov 1, 2023 · 5 comments · Fixed by #89
Labels
enhancement New feature or request

Comments

@northword
Copy link
Member

拆xpi包,读取manifest.json或install.rdf,补全空字段(如 描述);校验release.targetZoteroVersion与xpi定义的是否一致;补全id。

ref: #38 (review)

@northword northword added the enhancement New feature or request label Nov 1, 2023
@l0o0
Copy link
Contributor

l0o0 commented Nov 6, 2023

如果服务器资源可以允许解压读取,也是可以的。我当时就是担心git action 的资源处理这个,会不会太慢了。

@syt2
Copy link
Collaborator

syt2 commented Dec 14, 2023

currentVersion 字段表示的是xpi包发布所对应GitHub仓库内的tag名,非xpi包版本
是否考虑从xpi包中解析xpi的版本至一个新的字段,如xpiVersion

@northword
Copy link
Member Author

currentVersion 字段表示的是xpi包发布所对应GitHub仓库内的tag名,非xpi包版本 是否考虑从xpi包中解析xpi的版本至一个新的字段,如xpiVersion

tag 是否有用?无用的话把这个直接替换为 XPI 包中的版本也可

@syt2
Copy link
Collaborator

syt2 commented Dec 14, 2023

tag 是否有用?无用的话把这个直接替换为 XPI 包中的版本也可

有用的,下载量的标签会用

@northword
Copy link
Member Author

是否考虑从xpi包中解析xpi的版本至一个新的字段,如xpiVersion

那也可以。

或者也可以 tagName 替换成实际的tagName(也就是现在的currentVersion),然后currentVersion写成xpi包中的,这样可以少增加一个字段,可以减小json文件的体积。(如果tagName无用的话)

我在赶几个考核作业,可能要周末或下周才能搞了,也许你有时间和兴趣的话,可以 PR。

这个仓库的网站目前并不依赖这个json文件,如果你要 PR 的话,可以按你的需求改。

northword pushed a commit that referenced this issue Dec 14, 2023
ref: #41 

Co-authored-by: shenyutao <shenyutao@nutstore.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants