Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

editedBy item sort option for group libraries #153

Open
dstillman opened this issue Jun 21, 2023 · 0 comments · May be fixed by #154
Open

editedBy item sort option for group libraries #153

dstillman opened this issue Jun 21, 2023 · 0 comments · May be fixed by #154
Assignees
Labels
API Web Library Issues affecting the web library

Comments

@dstillman
Copy link
Member

Like addedBy, and can probably modify this block to support both createdByUserID and lastModifiedByUserID:

We don't have usernames in the dataserver DB, so the way we have to do this is super hacky, but it works. It also looks like we don't actually ever clear these tables, which isn't really a problem, but that also means we never update the usernames if they change. Using REPLACE instead of INSERT IGNORE should fix that, at a very minor performance cost.

The DB table is tmpCreatedByUsers, but that's fine — we don't need to rename it.

@dstillman dstillman added API Web Library Issues affecting the web library labels Jun 21, 2023
abaevbog added a commit to abaevbog/dataserver that referenced this issue Jun 22, 2023
/groups/X/items?sort=editedBy
Fixes: zotero#153
abaevbog added a commit to abaevbog/dataserver that referenced this issue Jun 22, 2023
abaevbog added a commit to abaevbog/dataserver that referenced this issue Jun 22, 2023
@abaevbog abaevbog linked a pull request Jun 22, 2023 that will close this issue
abaevbog added a commit to abaevbog/dataserver that referenced this issue Jun 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API Web Library Issues affecting the web library
Development

Successfully merging a pull request may close this issue.

2 participants