-
Notifications
You must be signed in to change notification settings - Fork 770
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOI web translator: Offer the current page as a choice among the multiple #3130
Open
zoe-translates
wants to merge
7
commits into
zotero:master
Choose a base branch
from
zoe-translates:issue3126-DOI-offer-current-website-as-choice-multiple
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
0978feb
DOI web translator: Offer the current page as a choice among the mult…
zoe-translates 41a5fcb
DOI.js: Don't offer current page if it may be a duplicate among the m…
zoe-translates 6885959
DOI.js: Guard "current web page" logic against malformed resolution r…
zoe-translates dd54971
DOI.js: Revise handling of current-page in multiple for Connector update
zoe-translates bd23c38
DOI.js: Simplification & more guards when building the multiple selec…
zoe-translates e51c0c3
DOI.js: More robust calculation of item dissimilarity
zoe-translates 676e9a8
DOI.js: Update function signature after rebase
zoe-translates File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To continue the discussion from #3130 (comment) ...
@dstillman
I'm afraid I may be misunderstanding something.
My understanding is that we're discussing about the text that is to appear in the "Zotero Item Selector" popup for the special "current web page" item. The object
select
here, passed toZotero.selectItems()
, is responsible for what the user sees in the Item Selector. This object is a simple mapping of string (DOI) -> string (title as shown to the user in the Item Selector).If I understand it, you would be saying that here what the translator should do was to put the current page's title as the value for the special item.
What I was asking was whether this could be sufficient for the "text substitution" (into the localized string for "current web page") to be implemented in the Connector. I was asking because I didn't understand how that could be done without any URL info present in the
select
object. But I may be missing something.