Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: (CNKI.js) Adapt to search pages; Update test cases #3193

Merged
merged 1 commit into from
Dec 1, 2023
Merged

fix: (CNKI.js) Adapt to search pages; Update test cases #3193

merged 1 commit into from
Dec 1, 2023

Conversation

jiaojiaodubai
Copy link
Contributor

  • Use monitorDOMChanges() to make search pages available.
  • Update test cases.
  • Adjusting code style to pass ESLint testing.
  • Replace deprecated substr() with substring().
  • Add defer: trueto test cases.

@jiaojiaodubai jiaojiaodubai changed the title fix: Adapt to search pages; Update test cases fix: (CNKI.js) Adapt to search pages; Update test cases Nov 28, 2023
@jiaojiaodubai jiaojiaodubai reopened this Nov 28, 2023
@dstillman dstillman merged commit 7bf0dfb into zotero:master Dec 1, 2023
2 checks passed
@dstillman
Copy link
Member

Thanks!

@@ -38,21 +38,7 @@

// Fetches RefWorks records for provided IDs and calls onDataAvailable with resulting text
// ids should be in the form [{dbname: "CDFDLAST2013", filename: "1013102302.nh"}]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Should update and move this comment in a future update, since the code it's referring to is now in scrape())

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants