Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clinicaltrials.gov: fix #3403 #3404

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

clinicaltrials.gov: fix #3403 #3404

wants to merge 2 commits into from

Conversation

jiaojiaodubai
Copy link
Contributor

@jiaojiaodubai jiaojiaodubai commented Jan 2, 2025 •
edited
Loading

I don't know whether we should consider investigators in 'Contacts and Locations' as author anytime.

AbeJellinek
AbeJellinek requested changes Jan 9, 2025
View reviewed changes
Copy link
Member

@AbeJellinek AbeJellinek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Just remove the debug, add a test for the page that was broken (if existing tests weren't already failing?) and this is good.

clinicaltrials.gov.js Outdated
@@ -107,12 +107,13 @@ function studiesJSONToItem(data) {

let authorModule = study.protocolSection.sponsorCollaboratorsModule;
let firstAuthor = authorModule.responsibleParty;
Z.debug(firstAuthor);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove

@jiaojiaodubai
Copy link
Contributor Author

if existing tests weren't already failing?

Outdated response data only appears in some rare cases, which were not found in the original test cases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AbeJellinek AbeJellinek Awaiting requested review from AbeJellinek

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jiaojiaodubai @AbeJellinek