Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert PurePath to Strings #4

Closed
wants to merge 1 commit into from

Conversation

dickermoshe
Copy link

Config setup function are typed to return str and return Path, this commit adds the str() around such instances.
Had error:

'PureWindowsPath' object has no attribute 'replace'

Traceback (most recent call last):
  File "C:\Users\<USERNAME>\Music\z\venv\Lib\site-packages\zotify\track.py", line 163, in download_track
    output_template = output_template.replace("{"+k+"}", fix_filename(extra_keys[k]))
                      ^^^^^^^^^^^^^^^^^^^^^^^
AttributeError: 'PureWindowsPath' object has no attribute 'replace'

Config setup function are typed to return `str` and return `Path`, this commit adds the `str()` around such instances.
@dickermoshe dickermoshe changed the title Convert PurePath the Strings Convert PurePath to Strings Apr 23, 2023
@zotify-dev
Copy link
Owner

Sounds good on paper but why does the patch just replace the contents of track.py with that of config.py? Could you please try that again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants