-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Documentation improvements #4
Conversation
dispatch_compiler.erl Replace unnesecarylly html Character Entity < to <<. Expanded the description of functions by -spec tag and EDoc tags. Simplify -spec description. EDoc Tune css stylesheet. GNUmakefile Add documentation targets for generation public and private documenation. rebar.config Add documentation generation and testing profiles. Add option to generate public and private documentation. .gitignore Add .gitignore option for generated documentation. test/dispatch_compiler_basic_SUITE.erl Fix "Warning: export_all"
It seems that the newest rebar3 does not support OTP 21 anymore, making the test fail. Maybe we can remove the 21 test and add 24? |
Yes. You are right. I add modification to |
In Zotonic 1.x only support 22.3 and later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
Nice that there is some work done on the documentation. Now that they are more readable, they should probably be pushed to hex as well.
Yes, Maas. You are right. I with Marc already have merged all of this using branch based on this one. It would be nice to merge this branch too in a way to save all that description related to this changes (saving this description for the history of changes.). I hope you can do it as good as possible. I usually add documentation and updates to my hex.pm area in this way:
|
And merged :-) |
Nice... For hex it is probably just a matter of building the documentation on the machine you push the hex package from. |
I have released 1.1.0 |
This is going to look like something real.. \o/... PS. @rustkas I used the same setup you provided for the type specs and doc strings in my educkdb package. (https://hexdocs.pm/educkdb/). So thanks a lot. |
Publishing documentation on hex.pm rebar3 projects has nuances which described on rebar3_publish. To comply with all conventions, it is necessary to follow his recommendations. I have already encountered some peculiarities of work when publishing documentation for Erlang libraries that I posted under my account. To do this I just add this to the rebar.config file:
I noticed that the configuration files of the Zotonic projects that I have already met has not yet had that settings. |
dispatch_compiler.erl
<
to<<
.-spec
tag and EDoc tags.EDoc
GNUmakefile
rebar.config
.gitignore
test/dispatch_compiler_basic_SUITE.erl