fix sonar

Signed-off-by: Andrea Tabone <andrea.tabone@broadcom.com>
zowe · Feb 10, 2025 · 862ab86 · 862ab86
1 parent dd26183
commit 862ab86
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 5 deletions.
diff --git a/...es/src/test/java/org/zowe/apiml/apicatalog/controllers/api/ApiCatalogControllerTests.java b/...es/src/test/java/org/zowe/apiml/apicatalog/controllers/api/ApiCatalogControllerTests.java
@@ -226,10 +226,10 @@ void thenReturnOk() throws ContainerStatusRetrievalThrowable {
             given(cachedApiDocService.getDefaultApiDocForService(serviceId)).willReturn("mockApiDoc");
 
             ResponseEntity<APIService> apiServicesById = underTest.getAPIServicesById(serviceId);
-            assertEquals(apiServicesById.getStatusCode(), HttpStatus.OK);
+            assertEquals(HttpStatus.OK, apiServicesById.getStatusCode());
             assertNotNull(apiServicesById.getBody());
-            assertEquals(apiServicesById.getBody().getApiDoc(), "mockApiDoc");
-            assertEquals(apiServicesById.getBody().getDefaultApiVersion(), "v1");
+            assertEquals( "mockApiDoc", apiServicesById.getBody().getApiDoc());
+            assertEquals("v1", apiServicesById.getBody().getDefaultApiVersion());
         }
 
         @Test
@@ -244,7 +244,7 @@ void thenReturnOkWithApiDocNull() throws ContainerStatusRetrievalThrowable {
             given(cachedApiDocService.getDefaultApiDocForService(serviceId)).willReturn(null);
 
             ResponseEntity<APIService> apiServicesById = underTest.getAPIServicesById(serviceId);
-            assertEquals(apiServicesById.getStatusCode(), HttpStatus.OK);
+            assertEquals(HttpStatus.OK, apiServicesById.getStatusCode());
             assertNotNull(apiServicesById.getBody());
             assertNull(apiServicesById.getBody().getApiDoc());
         }

diff --git a/api-catalog-ui/frontend/src/actions/user-actions.jsx b/api-catalog-ui/frontend/src/actions/user-actions.jsx
@@ -40,7 +40,6 @@ function login(credentials) {
                 if (credentials.newPassword) {
                     showUpdatePassSuccess = true;
                 }
-                const dashBoardPath = '/dashboard';
                 localStorage.setItem('username', credentials.username);
                 dispatch(success(token, showUpdatePassSuccess));
             },