Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

disable banner based on proposal in https://github.com/zowe/zlc/issue… #341

Merged
merged 2 commits into from
Aug 1, 2019
Merged

disable banner based on proposal in https://github.com/zowe/zlc/issue… #341

merged 2 commits into from
Aug 1, 2019

Conversation

vvvlc
Copy link
Contributor

@vvvlc vvvlc commented Jul 24, 2019

zowe/zac#90 (comment)

Signed-off-by: Vitek Vlcek vitezslav@vvvlcek.info

jandadav
jandadav previously requested changes Jul 24, 2019
View reviewed changes
Copy link
Contributor

@jandadav jandadav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i'd suggest not polluting the .sh files anymore, but rather would use banner in yaml or change the banner files themselves to be either empty or one-line messages that are not obtrusive and can be meaningful

@vvvlc
Copy link
Contributor Author

vvvlc commented Jul 24, 2019

i'd suggest not polluting the .sh files anymore, but rather would use banner in yaml or change the banner files themselves to be either empty or one-line messages that are not obtrusive and can be meaningful

If you are ok with disabling banners globally I'm fine with it.
I can change it.

@arxioly arxioly requested a review from JirkaAichler July 24, 2019 16:03
@codecov
Copy link

codecov bot commented Jul 26, 2019 •
edited
Loading

Codecov Report

Merging #341 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #341   +/-   ##
=========================================
  Coverage     70.21%   70.21%           
  Complexity       12       12           
=========================================
  Files           233      233           
  Lines          4321     4321           
  Branches        558      558           
=========================================
  Hits           3034     3034           
  Misses         1144     1144           
  Partials        143      143

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d83b784...6865f63. Read the comment docs.

@vvvlc vvvlc requested a review from jandadav July 26, 2019 14:54
JirkaAichler
JirkaAichler reviewed Jul 29, 2019
View reviewed changes
Copy link
Contributor

@JirkaAichler JirkaAichler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. However please make sure it passes the integration tests.

https://zikch01-l21930.lvn.broadcom.net/jenkins/job/MFaaS/job/MFD/job/ca-api-layer/job/ZOWE-PR-341/2/console

disable banner based on proposal in zowe/zac#90 (comment)
e39ade6 
banner cannot be enabled because it is displayed twice see spring-projects/spring-boot#17746

Signed-off-by: Vitek Vlcek <vitezslav@vvvlcek.info>
@vvvlc vvvlc mentioned this pull request Aug 1, 2019
Closed
@vvvlc
Copy link
Contributor Author

vvvlc commented Aug 1, 2019

thank you @ilkinabdullayev for nice workaroud

@vvvlc
Copy link
Contributor Author

vvvlc commented Aug 1, 2019

could you merge it in.?

JirkaAichler
JirkaAichler approved these changes Aug 1, 2019
View reviewed changes
Copy link
Contributor

@JirkaAichler JirkaAichler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you Ilkin and Vitek!

ilkinabdullayev
ilkinabdullayev approved these changes Aug 1, 2019
View reviewed changes
Copy link
Contributor

@ilkinabdullayev ilkinabdullayev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Vitek!

@ilkinabdullayev ilkinabdullayev dismissed jandadav’s stale review August 1, 2019 13:42

Solution was changed

@JirkaAichler JirkaAichler merged commit 4624fb1 into master Aug 1, 2019
@JirkaAichler JirkaAichler deleted the disable-banner branch August 1, 2019 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JirkaAichler JirkaAichler JirkaAichler approved these changes

@ilkinabdullayev ilkinabdullayev ilkinabdullayev approved these changes

@vsev0lod vsev0lod Awaiting requested review from vsev0lod

@arxioly arxioly Awaiting requested review from arxioly

@jandadav jandadav Awaiting requested review from jandadav

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@vvvlc @ilkinabdullayev @jandadav @JirkaAichler @zowe-robot