Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(v3): Make getJobsByParameters required and fix "Allocate Like" placeholder text #2764

Merged
merged 3 commits into from
Mar 7, 2024

Conversation

traeok
Copy link
Member

@traeok traeok commented Mar 5, 2024

Proposed changes

Resolves #2759

  • Breaking: Made getJobsByParameters required now that getJobsByOwnerAndPrefix has been removed
  • Fixed the issue where the "Allocate Like" placeholder contained an old ID from the previously used i18n localization.

Before:
image

After:
image

Release Notes

Milestone: v3

Changelog:

  • Breaking: Made MainframeInteraction.IJes.getJobsByParameters a required function now that getJobsByOwnerAndPrefix has been removed.
  • Fixed issue where "Allocate Like" input box placeholder was showing a localization ID instead of the intended message ("Enter a name for the new data set"). #2759

Types of changes

What types of changes does your code introduce to Zowe Explorer?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Updates to Documentation or Tests (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This checklist will be used as reference for both the contributor and the reviewer

  • I have read the CONTRIBUTOR GUIDANCE wiki
  • PR title follows Conventional Commits Guidelines
  • PR Description is included
  • gif or screenshot is included if visual changes are made
  • yarn workspace vscode-extension-for-zowe vscode:prepublish has been executed
  • All checks have passed (DCO, Jenkins and Code Coverage)
  • I have added unit test and it is passing
  • I have added integration test and it is passing
  • There is coverage for the code that I have added
  • I have tested it manually and there are no regressions found
  • I have added necessary documentation (if appropriate)
  • Any PR dependencies have been merged and published (if appropriate)

Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>
adam-wolfe
adam-wolfe previously approved these changes Mar 5, 2024
Copy link
Contributor

@adam-wolfe adam-wolfe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @traeok

anaxceron
anaxceron previously approved these changes Mar 5, 2024
Copy link
Contributor

@anaxceron anaxceron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a minor comment -- otherwise, loos good.

packages/zowe-explorer-api/CHANGELOG.md Outdated Show resolved Hide resolved
t1m0thyj
t1m0thyj previously approved these changes Mar 6, 2024
Copy link
Member

@t1m0thyj t1m0thyj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @traeok!

Should we remove all references to getJobsByOwnerAndPrefix from unit tests?

Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>
Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>
@traeok
Copy link
Member Author

traeok commented Mar 7, 2024

LGTM, thanks @traeok!

Should we remove all references to getJobsByOwnerAndPrefix from unit tests?

I've removed all references of getJobsByOwnerAndPrefix from the unit tests in commit e3787d5.

Copy link

sonarcloud bot commented Mar 7, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

codecov bot commented Mar 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.32%. Comparing base (7aaba1e) to head (abd6a6a).
Report is 5 commits behind head on next.

Additional details and impacted files
@@           Coverage Diff           @@
##             next    #2764   +/-   ##
=======================================
  Coverage   93.32%   93.32%           
=======================================
  Files         110      110           
  Lines       10246    10246           
  Branches     2103     2183   +80     
=======================================
  Hits         9562     9562           
  Misses        683      683           
  Partials        1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@zFernand0 zFernand0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the breaking item in the changelog.md file. 🥳

LGTM! 😋

@traeok traeok merged commit 1f4e305 into next Mar 7, 2024
21 checks passed
@traeok traeok deleted the fix/v3/misc-issues branch March 7, 2024 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Closed
Development

Successfully merging this pull request may close these issues.

V3: allocateLike.inputBox.placeHolder is displayed in the input box when a user clicks Allocate like...
5 participants