feat(v3-zftp): Update the zFTP VSCE with the V3 version of the plug-in

[zFernand0]

Proposed changes

• Update the zFTP extension to the V3 version of the plug-in.
• This includes a zos-node-accessor upgrade to V2 as well.
  • More details: V3 Conformance + zos-node-accessor update zowe-cli-ftp-plugin#155
• Adds eslint-plugin-deprecation
• Updates most devDeps for technical currency
• Fix Unable to create datasets on vNext #2770
  • See packages/zowe-explorer/src/PersistentFilters.ts

Release Notes

Milestone: v3

Changelog: Update the zos-node-accessor dependency

Types of changes

What types of changes does your code introduce to Zowe Explorer?
Put an x in the boxes that apply

• Bugfix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• Updates to Documentation or Tests (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This checklist will be used as reference for both the contributor and the reviewer

• I have read the CONTRIBUTOR GUIDANCE wiki
• PR title follows Conventional Commits Guidelines
• PR Description is included
• gif or screenshot is included if visual changes are made
• pnpm --filter vscode-extension-for-zowe vscode:prepublish has been executed
• All checks have passed (DCO, Jenkins and Code Coverage)
• I have added/modified unit test and it is passing
• I have added/modified integration test and it is passing
• There is coverage for the code that I have added
• I have tested it manually and there are no regressions found
• I have added necessary documentation/changelog (if appropriate)
• Any PR dependencies have been merged and published (if appropriate)

Further comments

Please note that errors from either a z/OSMF or a zFTP result in the Action bar getting stuck with the name of the action being performed (e.g. Opening USS File..., Downloading USS FIle...)

Here are some edge cases and how they are currently handled (marketplace) vs how they will be handled after this PR

• USS symbolic links to directories
  • Both (z/OSMF and zFTP) don't handle this scenario (marketplace, or this PR)
• USS symbolic links to files
  • z/OSMF and this PR handle them just fine
  • The zFTP version on the marketplace adds the link to the filename which causes a file-not-found error
    • 
• USS symbolic links to deleted files
  • z/OSMF and this PR throw an error a file-not-found error
  • The zFTP version on the marketplace also throws an error because of the filename having the link
• USS directory with * (or **, ***...) as the name
  • z/OSMF handles this as any other directory
  • Both zFTP (marketplace and this PR) show the contents on the outer directory as if everything is inside it (including itself)

    z/OSMF	zFTP

• USS files with special characters (e.g. start \ : * ? " < > | end.ext, /, ...)
  • z/OSMF handles everything but slashes (\ or /) in filenames
  • Both zFTP (marketplace and this PR) handle everything except / in filenames

[codecov]

Codecov Report

Attention: Patch coverage is 93.02326% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 93.38%. Comparing base (50eeee8) to head (c5dbe78).

Files	Patch %	Lines
...xplorer-ftp-extension/src/ZoweExplorerFtpJesApi.ts	86.95%	3 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             next    #2783      +/-   ##
==========================================
- Coverage   93.42%   93.38%   -0.05%     
==========================================
  Files         121      121              
  Lines       10857    10835      -22     
  Branches     2320     2312       -8     
==========================================
- Hits        10143    10118      -25     
- Misses        711      714       +3     
  Partials        3        3              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[traeok]

LGTM, thanks @zFernand0!

[JillieBeanSim]

I'm seeing some strange behavior with packaging and installing both extensions. When I created a new team config no base or ftp profile was put in the config. Also, when I first started I did the create steps to add ftp profile to existing config and it wasn't added. When I deleted that config to test starting fresh I saw strange behavior in tree where it didn't clear the profiles (this part could be unrelated but still a problem that should be documented).

after deleting config:

[t1m0thyj]

Looks pretty good, thanks @zFernand0! Left a few comments

[zFernand0]

Hey @JillieBeanSim,
I was able to reproduce the issue with the most recent vNext release (v3.0.0-next.202404242037). I'm looking into this a bit further, but I'll open it as a separate issue for now 😋

FWIW, testing with the pre-release version v3.0.0-next.202402142205 (more details on #2887) and this PR's FTP build (found here) the FTP and base profiles get created just fine 😋

Opened issue #2887

[sonarcloud]

Quality Gate passed

Issues
4 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.2% Duplication on New Code

See analysis details on SonarCloud

[zFernand0]

To make things easier for people to test this PR, feel free to get the VSIX files from the latest builds:

• ZE: https://github.com/zowe/zowe-explorer-vscode/actions/runs/8900831057?pr=2783
• zFTP: https://github.com/zowe/zowe-explorer-vscode/actions/runs/8900831065?pr=2783

[t1m0thyj]

LGTM, thanks @zFernand0!

[traeok]

LGTM, thanks @zFernand0 😁

[zFernand0]

Thanks for the reviews, @t1m0thyj, @traeok, and @JillieBeanSim! 🥳