-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(v3-zftp): Update the zFTP VSCE with the V3 version of the plug-in #2783
Conversation
Signed-off-by: zFernand0 <37381190+zFernand0@users.noreply.github.com>
Signed-off-by: zFernand0 <37381190+zFernand0@users.noreply.github.com>
Signed-off-by: zFernand0 <37381190+zFernand0@users.noreply.github.com>
…nto prep/ftp-v3 Signed-off-by: zFernand0 <37381190+zFernand0@users.noreply.github.com>
Signed-off-by: zFernand0 <37381190+zFernand0@users.noreply.github.com>
Signed-off-by: zFernand0 <37381190+zFernand0@users.noreply.github.com>
Signed-off-by: zFernand0 <37381190+zFernand0@users.noreply.github.com>
Signed-off-by: zFernand0 <37381190+zFernand0@users.noreply.github.com>
Signed-off-by: zFernand0 <37381190+zFernand0@users.noreply.github.com>
Signed-off-by: zFernand0 <37381190+zFernand0@users.noreply.github.com>
Signed-off-by: zFernand0 <37381190+zFernand0@users.noreply.github.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## next #2783 +/- ##
==========================================
- Coverage 93.42% 93.38% -0.05%
==========================================
Files 121 121
Lines 10857 10835 -22
Branches 2320 2312 -8
==========================================
- Hits 10143 10118 -25
- Misses 711 714 +3
Partials 3 3 ☔ View full report in Codecov by Sentry. |
Signed-off-by: zFernand0 <37381190+zFernand0@users.noreply.github.com>
Signed-off-by: zFernand0 <37381190+zFernand0@users.noreply.github.com>
Signed-off-by: zFernand0 <37381190+zFernand0@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @zFernand0!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm seeing some strange behavior with packaging and installing both extensions. When I created a new team config no base or ftp profile was put in the config. Also, when I first started I did the create steps to add ftp profile to existing config and it wasn't added. When I deleted that config to test starting fresh I saw strange behavior in tree where it didn't clear the profiles (this part could be unrelated but still a problem that should be documented).
after deleting config:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks pretty good, thanks @zFernand0! Left a few comments
Signed-off-by: zFernand0 <37381190+zFernand0@users.noreply.github.com>
Signed-off-by: zFernand0 <37381190+zFernand0@users.noreply.github.com>
Signed-off-by: zFernand0 <37381190+zFernand0@users.noreply.github.com>
Hey @JillieBeanSim, FWIW, testing with the pre-release version v3.0.0-next.202402142205 (more details on #2887) and this PR's FTP build (found here) the |
Quality Gate passedIssues Measures |
To make things easier for people to test this PR, feel free to get the VSIX files from the latest builds: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @zFernand0!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @zFernand0 😁
Thanks for the reviews, @t1m0thyj, @traeok, and @JillieBeanSim! 🥳 |
Proposed changes
zos-node-accessor
upgrade to V2 as well.zos-node-accessor
update zowe-cli-ftp-plugin#155eslint-plugin-deprecation
packages/zowe-explorer/src/PersistentFilters.ts
Release Notes
Milestone: v3
Changelog: Update the
zos-node-accessor
dependencyTypes of changes
What types of changes does your code introduce to Zowe Explorer?
Put an
x
in the boxes that applyChecklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This checklist will be used as reference for both the contributor and the reviewerpnpm --filter vscode-extension-for-zowe vscode:prepublish
has been executedFurther comments
Please note that errors from either a z/OSMF or a zFTP result in the Action bar getting stuck with the name of the action being performed (e.g.
Opening USS File...
,Downloading USS FIle...
)Here are some edge cases and how they are currently handled (marketplace) vs how they will be handled after this PR
*
(or**
,***...
) as the namestart \ : * ? " < > | end.ext
,/
, ...)\
or/
) in filenames/
in filenames