V1 - Updating the routing

[sakshibobade21]

Proposed changes

PR attempts to make requests to ZSS w/o any loopbacks to the App server.

Type of change

Please delete options that are not relevant.

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Change in a documentation
• Refactor the code
• Chore, repository cleanup, updates the dependencies.
• Breaking change (fix or feature that would cause existing functionality to not work as expected)

PR Checklist

Please delete options that are not relevant.

• If the changes in this PR are meant for the next release / mainline, this PR targets the "staging" branch.
• My code follows the style guidelines of this project (see: Contributing guideline)
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• New and existing unit tests pass locally with my changes
• video or image is included if visual changes are made
• Relevant update to CHANGELOG.md
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works, or describe a test method below

Testing

Further comments

[1000TurquoisePogs]

This has several problems.

1. if you parse and its not json, you will throw an exception
2. options.body type detection is already done around line 913
3. line 923 does JSON.stringify(), so this just reverses it. Choose one or the other.
4. isn't stringify better since thats what the network does? what issue is this solving?

[sakshibobade21]

Yes, stringify is better.
But Robert's team had created the test plugins to reproduce few errors.
And one of the errors occurred because they were accepting the parsed JSON body.

And hence I used JSON.parse() only for the requests that are routed internally.
So we still need to do JSON.stringify() at line 923 for other requests.

[1000TurquoisePogs]

OK, thank you for the explanation. A try-catch is still needed however because the body might not be json! If the body is a string, boolean, number... this will not work for other cases. Please check headers["Content-Type"] that was set in 923 or just optimistically try and then catch by saying that well, its not json I guess.

Also a code comment about why you're doing this will be great for the future when we wonder why it is the way it is.

[sakshibobade21]

Thank you.
Please let me know if the changes looks good to you or it's still more safer to use the try catch instead of if else.

[1000TurquoisePogs]

OK, thank you for the explanation. A try-catch is still needed however because the body might not be json! If the body is a string, boolean, number... this will not work for other cases. Please check headers["Content-Type"] that was set in 923 or just optimistically try and then catch by saying that well, its not json I guess.

Also a code comment about why you're doing this will be great for the future when we wonder why it is the way it is.

[1000TurquoisePogs]

Needs DCO fix.