Fix error using session with auth type "none"

[t1m0thyj]

What It Does

Fixes #2219

How to Test

Try issuing a REST request with no credentials on the session object:

const { RestClient, Session } = require("@zowe/imperative");
const mySession = new Session({
    hostname: "example.com",
    port: 443,
    type: "none"
});
const restClient = new RestClient(mySession);
restClient.request({ resource: "/", request: "GET" }).then(console.log);

Review Checklist
I certify that I have:

• tested my changes
• added/updated automated tests
• updated the changelog
• followed the contribution guidelines

Additional Comments

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.15%. Comparing base (de6aacc) to head (0c05bcc).

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #2218      +/-   ##
==========================================
- Coverage   91.16%   91.15%   -0.01%     
==========================================
  Files         638      638              
  Lines       19103    19103              
  Branches     3927     3974      +47     
==========================================
- Hits        17415    17414       -1     
- Misses       1687     1688       +1     
  Partials        1        1              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[zFernand0]

The change makes sense to me conceptually speaking.
I may need some help understanding it a bit better. 🙏🏽

LGTM though 😋

[traeok]

Changes look good to me, thanks Timothy for the quick fix

[anaxceron]

amazing!

[zFernand0]

Had a bit more time to test.
Thanks @t1m0thyj for helping! 🙏🏽

LGTM! 😋

Tested in 7.24.0 and this PR and they work as expected (no errors thrown).

Tested with 7.24.1 - a couple of versions in between - 7.28.2, and the latest vNext version and we get the error 😋

Also did some testing with varios Zowe bundles
2.9 - 2.15 (versions before CLI-7.24.1) and they all worked 😋
Then, 2.16 started to fail (as expected)

[gejohnston]

I agree with the implementation using AUTH_TYPE_NONE. AUTH_TYPE_NONE does not fall into our order-of-precedence. Its presence is an indicator that the items in our order-of-precedence do not even apply to the action.

I suppose AUTH_TYPE_NONE could be tested earlier and we could skip many of the credential checks, but then we would still have to set the headers and flags at the end of the function. Placing the test for AUTH_TYPE_NONE on an existing test (as you have done) minimizes the changes that have to be made, and may even make the logic easier for a human to follow.

[sonarcloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[github-actions]

Release succeeded for the master branch. 🎉

The following packages have been published:

• npm: @zowe/imperative@5.26.2
• npm: @zowe/cli-test-utils@7.28.3
• npm: @zowe/core-for-zowe-sdk@7.28.3
• npm: @zowe/zos-uss-for-zowe-sdk@7.28.3
• npm: @zowe/provisioning-for-zowe-sdk@7.28.3
• npm: @zowe/zos-console-for-zowe-sdk@7.28.3
• npm: @zowe/zos-files-for-zowe-sdk@7.28.3
• npm: @zowe/zos-logs-for-zowe-sdk@7.28.3
• npm: @zowe/zosmf-for-zowe-sdk@7.28.3
• npm: @zowe/zos-workflows-for-zowe-sdk@7.28.3
• npm: @zowe/zos-jobs-for-zowe-sdk@7.28.3
• npm: @zowe/zos-tso-for-zowe-sdk@7.28.3
• npm: @zowe/cli@7.28.3

_{Powered by Octorelease 🚀}