Add search callbacks to files SDK #2300
Open
+320
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andrew W. Harn <andrew.harn@broadcom.com>
awharn
requested review from
t1m0thyj,
gejohnston,
zFernand0,
traeok,
anaxceron,
jace-roell and
ATorrise
Signed-off-by: Andrew W. Harn <andrew.harn@broadcom.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2300 +/- ##
=======================================
Coverage 91.24% 91.24%
=======================================
Files 628 628
Lines 17867 17874 +7
Branches 3840 3843 +3
=======================================
+ Hits 16302 16309 +7
Misses 1564 1564
Partials 1 1 ☔ View full report in Codecov by Sentry. |
…allback. Signed-off-by: Andrew W. Harn <andrew.harn@broadcom.com>
anaxceron
reviewed
Oct 9, 2024
packages/zosfiles/CHANGELOG.md
Outdated
| @@ -2,6 +2,10 @@ | |||
|
|
|||
| All notable changes to the Zowe z/OS files SDK package will be documented in this file. | |||
|
|
|||
| ## Recent Changes | |||
|
|
|||
| - Enhancement: Added an optional `continueSearch` function to `ISearchOptions` to allow for user prompting and data set search cancellation after the list of data sets to be searched is retrieved. [#2300](https://github.com/zowe/zowe-cli/pull/2300) | |||
There was a problem hiding this comment.
I suggest rewording to something like: Added an optional continueSearch function to the ISearchOptions prompt/function/whatever. After an initial data set search has been executed, the new function can be set to prompt users to continue the existing search or cancel it.
There was a problem hiding this comment.
I made a change to try and follow that suggestion.
anaxceron
reviewed
Oct 9, 2024
Signed-off-by: Andrew W. Harn <andrew.harn@broadcom.com>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What It Does
Adds the ability to provide a function to the Data Sets search function, which is called if present and provided a list of data sets that are about to be searched. This allows extenders to prompt users asking if they want to continue a search, or automatically cancel a search if too many items are about to be searched. If not supplied, the search SDK keeps current behavior.
How to Test
Review Checklist
I certify that I have:
Additional Comments