Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add optional value to ISession for passed proxy values #2330

Merged
merged 15 commits into from
Nov 5, 2024

Conversation

JillieBeanSim
Copy link
Contributor

@JillieBeanSim JillieBeanSim commented Oct 29, 2024

What It Does
introduces an optional object in ISession for external proxy values to be sent by an extender like Zowe Explorer that would override the environment variable if set.

part one of ZE issue zowe/zowe-explorer-vscode#3010

How to Test

Review Checklist
I certify that I have:

Additional Comments

Signed-off-by: Billie Simmons <49491949+JillieBeanSim@users.noreply.github.com>
Signed-off-by: Billie Simmons <49491949+JillieBeanSim@users.noreply.github.com>
Signed-off-by: Billie Simmons <49491949+JillieBeanSim@users.noreply.github.com>
Signed-off-by: Billie Simmons <49491949+JillieBeanSim@users.noreply.github.com>
Signed-off-by: Billie Simmons <49491949+JillieBeanSim@users.noreply.github.com>
Signed-off-by: Billie Simmons <49491949+JillieBeanSim@users.noreply.github.com>
Copy link

codecov bot commented Oct 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.14%. Comparing base (c0f2fc0) to head (9d1d3ed).
Report is 16 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2330      +/-   ##
==========================================
+ Coverage   91.12%   91.14%   +0.01%     
==========================================
  Files         636      636              
  Lines       18011    18017       +6     
  Branches     3759     3873     +114     
==========================================
+ Hits        16413    16421       +8     
+ Misses       1597     1595       -2     
  Partials        1        1              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Billie Simmons <49491949+JillieBeanSim@users.noreply.github.com>
Signed-off-by: Billie Simmons <49491949+JillieBeanSim@users.noreply.github.com>
@JillieBeanSim JillieBeanSim marked this pull request as ready for review October 31, 2024 12:40
Copy link
Member

@gejohnston gejohnston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no objections to this PR. In a response comment within this PR, could you explain the customer scenarios that this change will improve - just to better my understanding of how this change helps end users.

@JillieBeanSim
Copy link
Contributor Author

JillieBeanSim commented Nov 1, 2024

Hey @gejohnston thanks, this addition will help extenders of the cli in VS Code and/or possibly other environments. An extender that is also a VS Code extension, ie. Zowe Explorer, may want to use the VS Code proxy settings instead of setting environment variables that are usually recognized by command line interfaces. if VSC proxy support is turned on, Zowe Explorer and it's extenders could allow users to set these values in the GUI interface and have them recognized with their rest calls.
Screenshot 2024-11-01 at 10 38 29 AM

Signed-off-by: Billie Simmons <BillieJean.Simmons@ibm.com>
Copy link
Member

@traeok traeok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks Billie for adding proxy support!

Copy link

sonarcloud bot commented Nov 4, 2024

Copy link
Member

@zFernand0 zFernand0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 😋

@zFernand0 zFernand0 merged commit e65624e into zowe:master Nov 5, 2024
14 checks passed
@zFernand0 zFernand0 added the release-current Indicates that there is no new functionality being delivered label Nov 5, 2024
@zFernand0
Copy link
Member

This should be on public NPM after this workflow is done:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-current Indicates that there is no new functionality being delivered
Projects
Status: Closed
Development

Successfully merging this pull request may close these issues.

5 participants