-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add optional value to ISession for passed proxy values #2330
Conversation
Signed-off-by: Billie Simmons <49491949+JillieBeanSim@users.noreply.github.com>
Signed-off-by: Billie Simmons <49491949+JillieBeanSim@users.noreply.github.com>
Signed-off-by: Billie Simmons <49491949+JillieBeanSim@users.noreply.github.com>
Signed-off-by: Billie Simmons <49491949+JillieBeanSim@users.noreply.github.com>
Signed-off-by: Billie Simmons <49491949+JillieBeanSim@users.noreply.github.com>
Signed-off-by: Billie Simmons <49491949+JillieBeanSim@users.noreply.github.com>
packages/imperative/src/rest/__tests__/client/ProxySettings.unit.test.ts
Fixed
Show fixed
Hide fixed
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2330 +/- ##
==========================================
+ Coverage 91.12% 91.14% +0.01%
==========================================
Files 636 636
Lines 18011 18017 +6
Branches 3759 3873 +114
==========================================
+ Hits 16413 16421 +8
+ Misses 1597 1595 -2
Partials 1 1 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Billie Simmons <49491949+JillieBeanSim@users.noreply.github.com>
Signed-off-by: Billie Simmons <49491949+JillieBeanSim@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have no objections to this PR. In a response comment within this PR, could you explain the customer scenarios that this change will improve - just to better my understanding of how this change helps end users.
Hey @gejohnston thanks, this addition will help extenders of the cli in VS Code and/or possibly other environments. An extender that is also a VS Code extension, ie. Zowe Explorer, may want to use the VS Code proxy settings instead of setting environment variables that are usually recognized by command line interfaces. if VSC proxy support is turned on, Zowe Explorer and it's extenders could allow users to set these values in the GUI interface and have them recognized with their rest calls. |
Signed-off-by: Billie Simmons <BillieJean.Simmons@ibm.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks Billie for adding proxy support!
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 😋
This should be on public NPM after this workflow is done: |
What It Does
introduces an optional object in ISession for external proxy values to be sent by an extender like Zowe Explorer that would override the environment variable if set.
part one of ZE issue zowe/zowe-explorer-vscode#3010
How to Test
Review Checklist
I certify that I have:
Additional Comments