Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added section on BiDi languages support #2114

Merged
merged 3 commits into from
Feb 9, 2023
Merged

Conversation

anaxceron
Copy link
Contributor

Added "Known Issues" section to ReadMe file, which contains a section titled "Bidirectional languages."

A user reached out to Brightside and asked about support for BiDi languages and was informed that VSC doesn't currently support these. (See Microsoft VSC Issue 86667)

Adding it to the ReadMe documentation in case of similar queries in the future. (Already added to Zowe Docs via PR 2634)

Signed-off-by: anaxceron <ana.ceron@broadcom.com>
@codecov
Copy link

codecov bot commented Feb 7, 2023

Codecov Report

Base: 89.25% // Head: 89.25% // No change to project coverage 👍

Coverage data is based on head (fdf76a2) compared to base (eaa3ed2).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2114   +/-   ##
=======================================
  Coverage   89.25%   89.25%           
=======================================
  Files          85       85           
  Lines        8081     8081           
  Branches     1704     1704           
=======================================
  Hits         7213     7213           
  Misses        867      867           
  Partials        1        1           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@zFernand0 zFernand0 added the no-changelog Add to PR's that don't require a CHANGELOG update label Feb 8, 2023
zFernand0
zFernand0 previously approved these changes Feb 8, 2023
Copy link
Member

@zFernand0 zFernand0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The contents LGTM! 😋

Signed-off-by: anaxceron <ana.ceron@broadcom.com>
@sonarcloud
Copy link

sonarcloud bot commented Feb 8, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@zFernand0 zFernand0 added this to the v2.7.0 milestone Feb 9, 2023
Copy link
Member

@traeok traeok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @anaxceron !

@zFernand0 zFernand0 merged commit b9089b0 into main Feb 9, 2023
@zFernand0 zFernand0 deleted the anax-BiDiLangReadMe-ZE branch February 9, 2023 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs no-changelog Add to PR's that don't require a CHANGELOG update
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants