Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare v2.12.0 release #2531

Merged
merged 3 commits into from
Nov 2, 2023
Merged

Prepare v2.12.0 release #2531

merged 3 commits into from
Nov 2, 2023

Conversation

JillieBeanSim
Copy link
Contributor

@JillieBeanSim JillieBeanSim commented Oct 27, 2023

Proposed changes

Release Notes

Milestone:

Changelog:

Types of changes

What types of changes does your code introduce to Zowe Explorer?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Updates to Documentation or Tests (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This checklist will be used as reference for both the contributor and the reviewer

  • I have read the CONTRIBUTOR GUIDANCE wiki
  • PR title follows Conventional Commits Guidelines
  • PR Description is included
  • gif or screenshot is included if visual changes are made
  • yarn workspace vscode-extension-for-zowe vscode:prepublish has been executed
  • All checks have passed (DCO, Jenkins and Code Coverage)
  • I have added unit test and it is passing
  • I have added integration test and it is passing
  • There is coverage for the code that I have added
  • I have tested it manually and there are no regressions found
  • I have added necessary documentation (if appropriate)
  • Any PR dependencies have been merged and published (if appropriate)

Further comments

Signed-off-by: Billie Simmons <49491949+JillieBeanSim@users.noreply.github.com>
@JillieBeanSim JillieBeanSim added the no-changelog Add to PR's that don't require a CHANGELOG update label Oct 27, 2023
@JillieBeanSim JillieBeanSim self-assigned this Oct 27, 2023
Signed-off-by: Billie Simmons <49491949+JillieBeanSim@users.noreply.github.com>
@codecov
Copy link

codecov bot commented Oct 30, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!.

Copy link
Member

@traeok traeok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've been using the "main VSIX" for a couple of days to prepare for the system demo, as well as to leverage sort/filtering in my day-to-day environment. I haven't run into any issues.

LGTM, thanks @JillieBeanSim!

@JillieBeanSim JillieBeanSim marked this pull request as ready for review October 30, 2023 18:11
Copy link
Contributor

@rudyflores rudyflores left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Created a PR against this branch for a bug I found with writing to credential manager, seems like if setting the secure setting to off it wouldn't set the override to false #2535

@adam-wolfe
Copy link
Contributor

Issue with sorting PDS members in descending order: #2536

@JillieBeanSim JillieBeanSim dismissed rudyflores’s stale review November 1, 2023 12:42

bug fix PRs merged into main

Copy link

sonarcloud bot commented Nov 1, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Contributor

@rudyflores rudyflores left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks to everyone that helped review the last minute finds on bugfixes!

Copy link
Member

@zFernand0 zFernand0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like we are ready to go.
LGTM! 😋

The only reason for requesting changes it to give Ana and others a chance to look over the changelog updates (which will be our release notes eventually)
👀 @anaxceron

@zFernand0 zFernand0 merged commit 69e21b0 into main Nov 2, 2023
26 checks passed
@zFernand0 zFernand0 deleted the 2.12.0-release branch November 2, 2023 15:09
Copy link

github-actions bot commented Nov 2, 2023

Release succeeded for the main branch. 🎉

The following packages have been published:

Powered by Octorelease 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-changelog Add to PR's that don't require a CHANGELOG update released
Projects
Status: Closed
Development

Successfully merging this pull request may close these issues.

7 participants